Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102800
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 104.47.37.126 cause and error)
To: Nikita Popov <nikita.ppv@gmail.com>
CC: PHP internals list <internals@lists.php.net>, Stanislav Malyshev
	<smalyshev@gmail.com>, "derick@derickrethans.nl" <derick@derickrethans.nl>,
	"Christoph M. Becker" <cmbecker69@gmx.de>
Thread-Topic: [PHP-DEV] re2c version(s)
Thread-Index: AQHUGobkns6AByBXsUi0THK3vWod/6SM4hIAgAAaAKQ=
Date: Fri, 13 Jul 2018 11:00:27 +0000
Message-ID:
 <BY1PR02MB1260229D19B14B069E2B66DDBF580@BY1PR02MB1260.namprd02.prod.outlook.com>
References:
 <BY1PR02MB1260706DBB8F5E3A36A2AEF2BF580@BY1PR02MB1260.namprd02.prod.outlook.com>,<CAF+90c_BGHBmUr1MjSXhJGhc8zJGQ67ynsn4QJhcsxo6iDWzNQ@mail.gmail.com>
In-Reply-To:
 <CAF+90c_BGHBmUr1MjSXhJGhc8zJGQ67ynsn4QJhcsxo6iDWzNQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY1PR02MB1260229D19B14B069E2B66DDBF580BY1PR02MB1260namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c6d6286f-deda-4e32-e14c-08d5e8afd781
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2018 11:00:27.4256
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR02MB1196
Subject: Re: [PHP-DEV] re2c version(s)
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY1PR02MB1260229D19B14B069E2B66DDBF580BY1PR02MB1260namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Nikita,


OK. Dropping files and requirement for re2c 1.0.0. Right?


Thanks. Dmitry.

________________________________
From: Nikita Popov <nikita.ppv@gmail.com>
Sent: Friday, July 13, 2018 12:26:22 PM
To: Dmitry Stogov
Cc: PHP internals list; Stanislav Malyshev; derick@derickrethans.nl; Christ=
oph M. Becker
Subject: Re: [PHP-DEV] re2c version(s)

On Fri, Jul 13, 2018 at 11:13 AM, Dmitry Stogov <dmitry@zend.com<mailto:dmi=
try@zend.com>> wrote:
Hi,


I think, many core developers saw unexpected changes in "zend_labguages_sca=
nner.c" or "var_unserializer.c" after rebuilds.

This occurs, because we use different versions of re2c, and some of them pr=
oduce really different code.

They also embed version number into the generate source. Currently differen=
t files in PHP source tree generated by different re2c versions:


ext/json/json_scanner.c 0.16

ext/date/lib/parse_date.c 0.15.3

ext/date/lib/parse_iso_intervals.c 0.15.3

ext/pdo/pdo_sql_parser.c 0.16

ext/phar/phar_path_check.c 1.0.3

sapi/phpdbg/phpdbg_lexer.c 0.16

ext/standard/url_scanner_ex.c 0.16

ext/standard/var_unserializer.c 1.0.1

Zend/zend_ini_scanner.c 0.15

Zend/zend_language_scanner.c 1.0.1


I propose, to change build scripts (in master and PHP-7.3) to require at le=
ast re2c version 1.0.0 (it seems 1.0.0-1.0.3 produce the same result) and s=
uppress version output into the generated files.


I'm not sure about timelib files.


Thanks. Dmitry.

I don't think normalizing the version really solves anything. These files s=
hould be dropped from version control entirely instead. Generated files do =
not belong in version control.

re2c is widely available on Linux distros nowadays (probably specifically b=
ecause PHP uses it) and while there might have been historical ground to bu=
ndle these generated files, there no longer is one.

Nikita

--_000_BY1PR02MB1260229D19B14B069E2B66DDBF580BY1PR02MB1260namp_--