Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:10274 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4354 invoked by uid 1010); 6 Jun 2004 07:22:43 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 4155 invoked from network); 6 Jun 2004 07:22:38 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 6 Jun 2004 07:22:38 -0000 Received: (qmail 1311 invoked from network); 6 Jun 2004 07:22:31 -0000 Received: from localhost (HELO zeev-laptop-new.zend.com) (127.0.0.1) by localhost with SMTP; 6 Jun 2004 07:22:31 -0000 Reply-To: zeev@zend.com Message-ID: <5.1.0.14.2.20040606101932.042535d8@localhost> X-Sender: zeev@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Sun, 06 Jun 2004 10:22:30 +0300 To: Stefan Esser Cc: internals@lists.php.net In-Reply-To: <40C25F90.3010109@php.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] ZE2 Patch From: zeev@zend.com (Zeev Suraski) References: <40C25F90.3010109@php.net> Good catch - go ahead and commit. Zeev At 03:04 06/06/2004, Stefan Esser wrote: >Hi, > >I could commit it myself but maybe you want to apply some cosmetic >fixes first. > >Stefan Esser > > > >diff -Nur php-5.0.0RC3RC2.orig/Zend/zend_compile.h >php-5.0.0RC3RC2/Zend/zend_compile.h >--- php-5.0.0RC3RC2.orig/Zend/zend_compile.h Tue Mar 16 20:46:04 2004 >+++ php-5.0.0RC3RC2/Zend/zend_compile.h Sun Jun 6 04:22:25 2004 >@@ -494,13 +494,14 @@ > ZEND_API int zend_cleanup_function_data(zend_function *function TSRMLS_DC); > > ZEND_API void destroy_zend_function(zend_function *function TSRMLS_DC); >+ZEND_API void zend_function_dtor(zend_function *function); > ZEND_API void destroy_zend_class(zend_class_entry **pce); > void zend_class_add_ref(zend_class_entry **ce); > > ZEND_API void zend_mangle_property_name(char **dest, int *dest_length, > char *src1, int src1_length, char *src2, int src2_length, int internal); > ZEND_API void zend_unmangle_property_name(char *mangled_property, char > **prop_name, char **class_name); > >-#define ZEND_FUNCTION_DTOR (void (*)(void *)) destroy_zend_function >+#define ZEND_FUNCTION_DTOR (void (*)(void *)) zend_function_dtor > #define ZEND_CLASS_DTOR (void (*)(void *)) destroy_zend_class > > zend_op *get_next_op(zend_op_array *op_array TSRMLS_DC); >diff -Nur php-5.0.0RC3RC2.orig/Zend/zend_opcode.c >php-5.0.0RC3RC2/Zend/zend_opcode.c >--- php-5.0.0RC3RC2.orig/Zend/zend_opcode.c Wed Feb 25 10:25:37 2004 >+++ php-5.0.0RC3RC2/Zend/zend_opcode.c Sun Jun 6 04:21:06 2004 >@@ -108,6 +108,13 @@ > } > } > >+ZEND_API void zend_function_dtor(zend_function *function) >+{ >+ TSRMLS_FETCH(); >+ >+ destroy_zend_function(function TSRMLS_CC); >+} >+ > static void zend_cleanup_op_array_data(zend_op_array *op_array) > { > if (op_array->static_variables) { > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php