Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102721
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.220 cause and error)
MIME-Version: 1.0
References: <CAF+90c9ogo6Y74xF_N0hiiNRH7=ZoS37DBAfPAUZFQuGkhQGaA@mail.gmail.com>
 <CADyq6sLZ8iMvY373orXr=xjs_44U7CSejEmZ33xynro0x-c0uw@mail.gmail.com>
 <CAESVnVrq-8rHctivmcWo2U+PaYcQxaW9j1G9wi-0sLYS0Kf-nQ@mail.gmail.com> <CAFMT4Nqq6eRAvVO81SupJJABwyvvhGQi1OaD064tAJAC1mLmPg@mail.gmail.com>
In-Reply-To: <CAFMT4Nqq6eRAvVO81SupJJABwyvvhGQi1OaD064tAJAC1mLmPg@mail.gmail.com>
Date: Tue, 10 Jul 2018 18:54:18 +0200
Message-ID: <CANUQDCgTJ+Y=3vC5nv4+7rWub61MGbQK3Z_d_ufPeZ1O5TSTgw@mail.gmail.com>
To: Levi Morrison <levim@php.net>, Marco Pivetta <ocramius@gmail.com>
Cc: Sara Golemon <pollita@php.net>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.3
From: me@kelunik.com (Niklas Keller)

I put that item onto the list.

The author of https://github.com/mikey179/bovigo-assert originally had
the issue that a function named `assert` behaves really weird.
`assert()` in namespaced code might refer to the namespaced `assert()`
function, but might also fall back to the global `assert()`. Whether
the function is jumped around or not depends on `zend.assertions`,
which is highly surprising, because it also jumps around `assert()` in
namespaced code even if an `assert()` function exists in that
namespace. Requiring an explicit `use function` is really weird.

See https://3v4l.org/8EKdA for an example. The behavior in PHP 7.0+ is
by-design and mentioned in the original assertions RFC.

Regards, Niklas
Am Mo., 9. Juli 2018 um 17:18 Uhr schrieb Levi Morrison <levim@php.net>:
>
> On Mon, Jul 9, 2018 at 8:43 AM Sara Golemon <pollita@php.net> wrote:
> >
> > On Mon, Jul 9, 2018 at 5:57 AM, Marco Pivetta <ocramius@gmail.com> wrote:
> > > Something unclear to me here: is the removal of `assert()` affecting also
> > > my own`my\assert()` (imported via `use function`)?
> > >
> > Yes, but in fairness, your namespaced assert function is already a bit
> > broken if you're not expecting it to be elided in production
> > environments.
> >
> > -Sara
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
>
> Can you prove this somehow? Based on how `use function my\assert;`
> works a call to `assert()` later in that file should appear to engine
> as `my\assert`, not `assert`.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>