Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102713
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.15 as permitted sender)
To: Derick Rethans <derick@php.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Jan Ehrhardt <phpdev@ehrhardt.nl>,
 PHP internals <internals@lists.php.net>
References: <d2952f0e-9bcf-1ea5-4768-603e4ee37394@gmx.de>
 <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com>
 <87863116-5de1-c44d-d751-51e9327807f2@gmx.de>
 <66c6jdhurlnsaqlegs0epd56b7skj0n20v@4ax.com>
 <6fa23528-ddcd-d998-50cd-ddabcb038b45@gmx.de>
 <CABBJUpeUT2k4BxuJ1jZz_vtvA44isnxAFfOWADbSrN4KvO-KEw@mail.gmail.com>
 <ed925804-1db0-fa44-11e7-4277a807c2b4@gmx.de>
 <lovnjd57c3vo3kbkfbkffc5e987cv1fqbt@4ax.com>
 <9274549c-4d08-7a68-77c3-aedfe6dc0962@gmx.de>
 <CAF+90c-ae577Rs2wo3MjLc8Mi4H7Vp5fR_L7HFEWwGhuOnEOBw@mail.gmail.com>
 <95d3db78-235e-ae54-4d24-8088914afad0@gmx.de>
 <alpine.DEB.2.21.1807091040560.2669@singlemalt.home.derickrethans.nl>
Message-ID: <1da47ccf-15a6-7691-1120-6293995431b7@gmx.de>
Date: Tue, 10 Jul 2018 15:48:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1807091040560.2669@singlemalt.home.derickrethans.nl>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 09.07.2018 at 11:41, Derick Rethans wrote:

> On Wed, 4 Jul 2018, Christoph M. Becker wrote:
> 
>> On 04.07.2018 at 12:24, Nikita Popov wrote:
>>
>>> On Wed, Jul 4, 2018 at 11:32 AM, Christoph M. Becker <cmbecker69@gmx.de>
>>> wrote:
>>>
>>>> On 04.07.2018 at 01:16, Jan Ehrhardt wrote:
>>>>
>>>>> Another one: some extensioms suffer from the fact that the macro GC_G
>>>>> was removed from
>>>>> https://github.com/php/php-src/blob/master/Zend/zend_gc.h
>>>>> Some of the removed functionality has been reintroduced in gc_status
>>>>> https://github.com/php/php-src/commits/master/Zend/zend_gc.h
>>>>>
>>>>> Examples using GC_G: v8js, xdebug, tideways.
>>>>> v8js was using gc_active to check if garbage collection was running.
>>>>> I did a wild guess to fix it:
>>>>> https://github.com/Jan-E/v8js/commit/997df065d3cd06a9b11e399458c391
>>>> eb797a850e#diff-dc446a69201ccda44a33d111152f6c8c
>>>>
>>>> This looks wrong, since zend_gc_collect_cycles() actually triggers the
>>>> GC, if I'm not mistaken.
>>>>
>>>> It seems to me that should be something like:
>>>>
>>>>   zend_gc_status status;
>>>>   zend_gc_get_status(&status);
>>>>   if (status.runs) {
>>>>
>>>
>>> The correct way to handle this is to implement a proper get_gc() handler,
>>> which will be called in favor of get_properties() during GC.
>>
>> Ah, thanks!  In some other cases, for instance, in Xdebug[1], using
>> zend_gc_get_status() would be correct, wouldn't it?
>>
>> [1]
>> <https://github.com/xdebug/xdebug/blob/27e20b16d23ab611d2a8e74d2e3c061710e18d8f/xdebug_gc_stats.c#L47-L57>
> 
> It should be - care to make a patch? :-) Xdebug also doesn't do the hash 
> protections correctly yet. I've not had the time to make a fix for that 
> yet either (hint!) ;-)

I'm already working on that.  I'll submit a (partial?) PR ASAP.

-- 
Christoph M. Becker