Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102692
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <8jq8kdlrqnaiego6no06osfq2ciao11tdm@4ax.com>
References: <8jq8kdlrqnaiego6no06osfq2ciao11tdm@4ax.com>
Date: Tue, 10 Jul 2018 12:12:47 +0200
Message-ID: <CAF+90c9=mrYr7nQ4rRP=8O-f_gtxHtsz4LBjp+7dXK_vnidWeA@mail.gmail.com>
To: Jan Ehrhardt <phpdev@ehrhardt.nl>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000348d840570a25f8e"
Subject: Re: [PHP-DEV] libmbfl API changes in PHP 7.3
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000348d840570a25f8e
Content-Type: text/plain; charset="UTF-8"

On Tue, Jul 10, 2018 at 10:30 AM, Jan Ehrhardt <phpdev@ehrhardt.nl> wrote:

> While trying to make the mailparse extension fit for PHP 7.3 I ran into
> changes in the libmbfl API. I cannot find any documentation on this
> change.
>
> The change was introduced in this commit by nikic:
> https://github.com/php/php-src/commit/b3c1d9d1118438a3dae3544447db2b
> 39ca5cfa25
>
> To be specific:
> https://github.com/php/php-src/commit/b3c1d9d1118438a3dae3544447db2b
> 39ca5cfa25#diff-929fd74a8732776fa8776939a9b907d4L71
>
> It broke the code of the mailparse extension at this line:
> https://github.com/php/pecl-mail-mailparse/blob/master/
> php_mailparse_mime.c#L910
>
> Shouldn't the be documented? And/or is there an easy fix?
>

Thanks for pointing this out, this should be added to UPGRADING.INTERNALS.
mbstring and libmbfl underwent some larger refactorings in PHP 7.3, to make
its performance less abysmally bad.

The change you are running into is that many APIs have changed from working
with enum mbfl_no_encoding to const mbfl_encoding *. You will have to
mirror these changes: For example, instead of passing mbfl_no_encoding_8bit
to a function, you use &mbfl_encoding_8bit. Instead of calling
mbfl_name2no_encoding(part->content_transfer_encoding) you instead use
mbfl_name2encoding(part->content_transfer_encoding) and so on.

Nikita

--000000000000348d840570a25f8e--