Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102690 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74064 invoked from network); 10 Jul 2018 10:04:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jul 2018 10:04:15 -0000 Authentication-Results: pb1.pair.com smtp.mail=cmbecker69@gmx.de; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=cmbecker69@gmx.de; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.18 as permitted sender) X-PHP-List-Original-Sender: cmbecker69@gmx.de X-Host-Fingerprint: 212.227.15.18 mout.gmx.net Received: from [212.227.15.18] ([212.227.15.18:40927] helo=mout.gmx.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5F/CF-49043-C94844B5 for ; Tue, 10 Jul 2018 06:04:13 -0400 Received: from [192.168.2.101] ([79.222.41.233]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M5LJv-1g0i0M2ENb-00zUpm; Tue, 10 Jul 2018 12:04:09 +0200 To: Jan Ehrhardt , internals@lists.php.net References: <8jq8kdlrqnaiego6no06osfq2ciao11tdm@4ax.com> Message-ID: <64dbb0c4-f960-9025-99ed-08d624864977@gmx.de> Date: Tue, 10 Jul 2018 12:04:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <8jq8kdlrqnaiego6no06osfq2ciao11tdm@4ax.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:QsjJ66ys5Xzh8uA4wRcjEljyPE//d6GklPsl4YUle6Pvujb6atO 0F8a8fwkQHCMcdJ0NxPx8G2OhxAnPysq/ibBeOrym02pjFtxmtGYZjIPyevuuKDmYhuux8O nNOn6MgCfQqhPKrUzypCWQD0dXAsAnsFW3rC3CnMnZoI+vWxMyOV6OElW68QLwWrTUo3sQA rCzkTWZoCPvQ112T+a0BA== X-UI-Out-Filterresults: notjunk:1;V01:K0:pu9R2smZTCg=:qu5JSJ6DnyET8Y8hngoUqo 2ecWlvJv1CCLWclNkNRuVviqKchj/W6yI5DT9/pxFOMNDQa5XD7bSImYNKnNw7bZKkmm9vxSp BspQeLckX/otP4LKUwhjrroJRwxIA+WL7JW299WhiQ/C7VU5QwNYXjWKEVvx2vFleiZuEQAIw Ah6FdcmFtqq5vuxX9U6gU7t3PjlmhRx3nzTu5oUZnByXZnkHgHkiDfxk6HGiHFh+qTlh3KUvF MftDwcGmkAMAnyb9wyVNq5HWqfClqmarxxtBpFO0uXTkx34e8Q8Fyt2FWiMXdIa1ksWV5vrAD HAyNMMH9fU1ALKm8p8nwsa5Kt4rImjEr3izM+5kq4S+eNWt7Xpvt261H5iaTXSV+HDZBugLYW 2ufTf6ZFjv4zg/Ui3jTkPS94YyJimAz6aeqLKeV1Kunllj3RsqtBNWa3JRVYs45hXSxxJQGFq 0VTZD5QwTU8E5O5UkfR7/6TTicqpMdK8I1VdQG6VWHaPy1st0YmvkWH0Szt5Ma7Q75hSsHbFj hL6R62vt8QGhrPtynMCdSLufq1kgzI6KwpiBKCNv2M4SdzWjI1I9Qcx6HoYsaViAv6sIJxrVq diKNbpBM/FGcU1YyKoIiAsYJA6SqfPq4NifBIIdome0mFcH7OmvVDXEqBFQwViZbMtLJb84oG ckgU2ZHH5nNLHmK7MYeer5nNT4Nkpr7qBysY5JgvgRIeocoXXWuCny+Dp0HPj+uOYkSWXPncn 1MBrAKDbe4lsGUQn33SgZqKB6qmJMU/aymdK3/wkAkkfvnnmbMoNlhAeeRohxoGODLTtmRrSy jZIl38L Subject: Re: libmbfl API changes in PHP 7.3 From: cmbecker69@gmx.de ("Christoph M. Becker") On 10.07.2018 at 10:30, Jan Ehrhardt wrote: > While trying to make the mailparse extension fit for PHP 7.3 I ran into > changes in the libmbfl API. I cannot find any documentation on this > change. > > The change was introduced in this commit by nikic: > https://github.com/php/php-src/commit/b3c1d9d1118438a3dae3544447db2b39ca5cfa25 > > To be specific: > https://github.com/php/php-src/commit/b3c1d9d1118438a3dae3544447db2b39ca5cfa25#diff-929fd74a8732776fa8776939a9b907d4L71 > > It broke the code of the mailparse extension at this line: > https://github.com/php/pecl-mail-mailparse/blob/master/php_mailparse_mime.c#L910 > > Shouldn't the be documented? And/or is there an easy fix? Have you tried to convert the first two arguments via mbfl_no2encoding()[1]? Anyhow, it seems to me that we should document why “--with-libmbfl is no longer available” (UPGRADING); because the bundled libmfl is now mandatory, since it has been changed, and at least to superficially add some respective notes to UPGRADING.INTERNALS. [1] -- Christoph M. Becker