Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102685 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62501 invoked from network); 10 Jul 2018 08:30:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jul 2018 08:30:40 -0000 X-Host-Fingerprint: 62.251.31.78 monitor.xs4all.nl Received: from [62.251.31.78] ([62.251.31.78:15824] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 17/BD-49043-CAE644B5 for ; Tue, 10 Jul 2018 04:30:38 -0400 To: internals@lists.php.net Date: Tue, 10 Jul 2018 10:30:33 +0200 Message-ID: <8jq8kdlrqnaiego6no06osfq2ciao11tdm@4ax.com> X-Newsreader: Forte Agent 3.3/32.846 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Posted-By: 62.251.31.78 Subject: libmbfl API changes in PHP 7.3 From: phpdev@ehrhardt.nl (Jan Ehrhardt) While trying to make the mailparse extension fit for PHP 7.3 I ran into changes in the libmbfl API. I cannot find any documentation on this change. The change was introduced in this commit by nikic: https://github.com/php/php-src/commit/b3c1d9d1118438a3dae3544447db2b39ca5cfa25 To be specific: https://github.com/php/php-src/commit/b3c1d9d1118438a3dae3544447db2b39ca5cfa25#diff-929fd74a8732776fa8776939a9b907d4L71 It broke the code of the mailparse extension at this line: https://github.com/php/pecl-mail-mailparse/blob/master/php_mailparse_mime.c#L910 Shouldn't the be documented? And/or is there an easy fix? -- Jan