Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102650
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJW__o1wjqVNgsbGQvKNYBdT8NUa+aJjiOsRToP6OcnQybxN_w@mail.gmail.com>
References: <CAF+90c_+GZNrV1SC9q=Y3C=L3LMnoXX7J3zK6=kS9-sMXHZZow@mail.gmail.com>
 <CAJW__o3BsiUoMwxhwPwBwY+OTPt1f=O6aQsHBot-Dat3MRCBpg@mail.gmail.com>
 <CAF+90c_x5ad+oAdPRKaEasMGAUyK+UELHnPEai-aOAPquKVySA@mail.gmail.com>
 <5153610d-abed-b21a-ec55-56d967128cae@gmail.com> <CAJW__o3smiKaCQOFSYqtQzPZJb2=iuR0RojWqshoOadFD7-vHg@mail.gmail.com>
 <CAF+90c8z-r4aL8ZVOCU+3V4tc3R2dhWXbDgXc+sOy3Cnb6i=sg@mail.gmail.com>
 <CAJW__o0EEABZDzg9CbPgRfY5u_DUL4+fUbbn3VDzuK0nseeiOQ@mail.gmail.com> <CAJW__o1wjqVNgsbGQvKNYBdT8NUa+aJjiOsRToP6OcnQybxN_w@mail.gmail.com>
Date: Sun, 8 Jul 2018 23:18:39 +0200
Message-ID: <CAF+90c8v15GXSCofiq4_s51_+fQguHgJF=4OVGiKOYF1BgkaCA@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e2216f05708370e2"
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000e2216f05708370e2
Content-Type: text/plain; charset="UTF-8"

On Fri, Jul 6, 2018 at 6:50 AM, Kalle Sommer Nielsen <kalle@php.net> wrote:

> Den tor. 5. jul. 2018 kl. 22.51 skrev Kalle Sommer Nielsen <kalle@php.net
> >:
> >
> > Den tor. 5. jul. 2018 kl. 22.46 skrev Nikita Popov <nikita.ppv@gmail.com
> >:
> > > Sounds reasonable to me. My only question would be when we would start
> emitting the deprecation notice. I'm not a fan of deprecating things in the
> same release as the alternative is introduced, so I would suggest to add
> the new alias in PHP 7.3 and perform the deprecation in PHP 7.4.
> >
> > I agree here, I don't think a simple constant would hurt too much to
> > add outside the scope of this RFC so I will go ahead and do soonish
> > that if no one else objects. Then we can move the section to the 7.4
> > Deprecation WIP RFC.
>
> I wrote a quick patch[1] for this (look away from the deprecation
> warning), which basically adds a new alias 'add_slashes', this seemed
> like the easiest way to go about it. While looking into ext/filter it
> seems there are no implementations for INPUT_SESSION and
> INPUT_REQUEST. I doubt there is any intention to implement these so
> they could be potentials for adding a deprecation for (or simply
> removal as they just yield an E_WARNING when used anyway)[2].
>
>
> [1] https://gist.github.com/KalleZ/cce52f230d599501373b15729ec85bfc
> [2] https://git.php.net/?p=php-src.git;a=blob;f=ext/filter/filter.c;h=
> 56c93199f0bf4f713eeb81c0dfddb910b02b9618;hb=HEAD#l547
>

I assume that we're going forward with the addition of the alias, so I
moved the FILTER_SANITIZE_MAGIC_QUOTES deprecation from the PHP 7.3 to the
PHP 7.4 deprecations RFC.

I'll start the vote on this RFC (and the case-insensitive constants RFC)
tomorrow, with a duration of one week. I was holding off on these votes
because earlier comments in the typed references RFC thread made it appear
like a change to the release schedule was imminent, but as the RMs haven't
made a final decision yet and I can't hold off these votes further, I'll
have to keep them within the current schedule

Nikita

--000000000000e2216f05708370e2--