Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102643
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain ncsu.edu from 209.85.218.45 cause and error)
MIME-Version: 1.0
References: <CADMz3wcm6QbCWdW_-W1rceMrDjgiPL+yJb87c0yiUG+2G7QSGQ@mail.gmail.com>
 <CAGa2bXZ7F=N9qp_WKTu=f4viM5t03WLPQu4MWJhvvaF37b-V6A@mail.gmail.com>
In-Reply-To: <CAGa2bXZ7F=N9qp_WKTu=f4viM5t03WLPQu4MWJhvvaF37b-V6A@mail.gmail.com>
Date: Sat, 7 Jul 2018 19:49:36 -0400
Message-ID: <CADMz3wdY5roZdYL2Eorq7Ui4a5uJBaemEXu-fLH1S6aN-oEhSg@mail.gmail.com>
To: yohgaki@ohgaki.net
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007f8e630570716f81"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Class Friendship
From: mdwheele@ncsu.edu (Dustin Wheeler)

--0000000000007f8e630570716f81
Content-Type: text/plain; charset="UTF-8"

On Sat, Jul 7, 2018 at 6:46 PM Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

>
>  I would like to vote to "yes".
> However, RFC does not have benchmark result. Do you have some results?
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
>
I have not run a benchmark on the current implementation but would be happy
to (and also attach that to the results of the RFC, pass or fail). Since
there really isn't a good way to test this exact behaviour against master
(since it doesn't exist), do you have any ideas for a reasonable benchmark?
The only added clock time should be attaching "friended" classes to the
"friending" zend_class_entry and an additional runtime check for
`protected` member access. What about the following:

For master (control):

```
class Readable {
  public $property = 'foo';
}

class Reader {
  public function read(Readable $object) {
    echo $object->property;
  }
}

$readable = new Readable();
$reader = new Reader();

// Time the following...
for ($i = 0; $i < 10000; $i++) {
  $reader->read($readable);
}
```

For RFC (experiment):

```
class NotReadable {
  friend Reader;

  protected $property = 'foo';
}

class Reader {
  public function read(NotReadable $object) {
    echo $object->property;
  }
}

$not_readable = new NotReadable();
$reader = new Reader();

// Time the following...
for ($i = 0; $i < 10000; $i++) {
  $reader->read($not_readable);
}
```

If you have any better idea, let me know and I can move forward. Also, if
there is some "standard" benchmark you'd like me to run, please let me know.

Thanks!

-- 
Dustin Wheeler | Software Developer
NC State University
mdwheele@ncsu.edu
"If you don't know where you're going, it's easy to iteratively not get
there."

--0000000000007f8e630570716f81--