Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102641
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender)
MIME-Version: 1.0
References: <CADMz3wcm6QbCWdW_-W1rceMrDjgiPL+yJb87c0yiUG+2G7QSGQ@mail.gmail.com>
In-Reply-To: <CADMz3wcm6QbCWdW_-W1rceMrDjgiPL+yJb87c0yiUG+2G7QSGQ@mail.gmail.com>
Date: Sun, 8 Jul 2018 07:45:40 +0900
Message-ID: <CAGa2bXZ7F=N9qp_WKTu=f4viM5t03WLPQu4MWJhvvaF37b-V6A@mail.gmail.com>
To: mdwheele@ncsu.edu
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000061a66c0570708c98"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Class Friendship
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--00000000000061a66c0570708c98
Content-Type: text/plain; charset="UTF-8"

On Sat, Jul 7, 2018 at 5:26 AM Dustin Wheeler <mdwheele@ncsu.edu> wrote:

> Hello,
>
> I've let this RFC linger for a long time and finally wrapped up the
> remaining administrative items to put it to vote. This has been
> discussed a few times in the past:
>
> https://externals.io/message/89732
> https://externals.io/message/90311
>
> I would like to open the vote for an RFC to support Class Friendship in
> PHP:
>
> https://wiki.php.net/rfc/friend-classes
>
> The vote ends 2018-07-13 21:00 UTC.
>
>
"Friend" is powerful feature when classes are required to have "tight
coupling",
even if "tight coupling" is bad thing to have in general.

Most obvious use case is "testing classes".
Tests require tight coupling because tests have to know and test class
internals
to perform detailed tests.

With "friend", we can remove A LOT of access methods solely for testing
class.
Less codes means less complexity. Having many codes for tests in production
classes does not make much sense also. Having a lot of getter/setter
methods
for testing is pain and this fact leads developers to write inferior tests.

"Friend" makes UNIT test and Contract Programming much simpler and easier.
Therefore, it helps to develop more robust apps.

Obvious risk is "friend abuse" where "tight coupling" isn't required nor
useful.
Big warning in the doc would be enough to prevent users from shooting their
own foot. There are features like "friend", e.g. $GLOBALS

I understand concerns, however simpler/cleaner production classes without
test only methods and having detailed tests is worth to have.

 I would like to vote to "yes".
However, RFC does not have benchmark result. Do you have some results?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--00000000000061a66c0570708c98--