Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102622 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48889 invoked from network); 6 Jul 2018 04:50:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Jul 2018 04:50:56 -0000 Authentication-Results: pb1.pair.com smtp.mail=kalle.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=kalle@php.net; sender-id=unknown Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.68 as permitted sender) X-PHP-List-Original-Sender: kalle.php@gmail.com X-Host-Fingerprint: 209.85.218.68 mail-oi0-f68.google.com Received: from [209.85.218.68] ([209.85.218.68:45125] helo=mail-oi0-f68.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D8/A9-55607-B25FE3B5 for ; Fri, 06 Jul 2018 00:50:52 -0400 Received: by mail-oi0-f68.google.com with SMTP id m2-v6so21118547oim.12 for ; Thu, 05 Jul 2018 21:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ewfDMkQFgx5EriVoHwsThYiwW+xA3/HAEJO8u1/vYaI=; b=eKFQkVCchCe+C6mB8nS+6g84pcSIlJgWwWA5e/ToSre1czthKriJ5/Wkf8/4FHROkY XLn08wtQ21crb7rmBuknxA194OWw7vVFmbbkYtQMlz49lp22pbF5RLv2wyTf/006aiG4 i1++FRCqy+w9IQkSEPnaEblK/2l1/GK5Ky/BCm6VYJx9Q2lQWF6cgd7j136zk2VAylJw l+f9Bb2wpFq6Jtt+pJd0qvcFsD8dqyK2eLAolCasyWN0HSXMZpx++e/LPTksCb2Jv1j9 ON/ct5ebOkFif46cM/HBfU12BJN/0HvAygntMseR+JsIgCheQlMpS8RIODo24YwUsT4h lobQ== X-Gm-Message-State: APt69E24TSKwr1HTtzIKnw9sNW+1Uii/IMU5kYRhV07vw9rf/NfVtuUw aTELkwdajMRSbevamLchIumN/XDkaxBcsXSyY7I= X-Google-Smtp-Source: AAOMgpfn8K4Vtj8PONLQ+mUF9ILnpuxO/UQW8FdODKsmewcHREezzWnxY1X3YIWIqj4mep1oBWQdkSupFh8ExSkJC/g= X-Received: by 2002:aca:4bc6:: with SMTP id y189-v6mr9469280oia.181.1530852648807; Thu, 05 Jul 2018 21:50:48 -0700 (PDT) MIME-Version: 1.0 References: <5153610d-abed-b21a-ec55-56d967128cae@gmail.com> In-Reply-To: Date: Fri, 6 Jul 2018 06:50:38 +0200 Message-ID: To: Nikita Popov Cc: Stas Malyshev , Internals Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3 From: kalle@php.net (Kalle Sommer Nielsen) Den tor. 5. jul. 2018 kl. 22.51 skrev Kalle Sommer Nielsen : > > Den tor. 5. jul. 2018 kl. 22.46 skrev Nikita Popov = : > > Sounds reasonable to me. My only question would be when we would start = emitting the deprecation notice. I'm not a fan of deprecating things in the= same release as the alternative is introduced, so I would suggest to add t= he new alias in PHP 7.3 and perform the deprecation in PHP 7.4. > > I agree here, I don't think a simple constant would hurt too much to > add outside the scope of this RFC so I will go ahead and do soonish > that if no one else objects. Then we can move the section to the 7.4 > Deprecation WIP RFC. I wrote a quick patch[1] for this (look away from the deprecation warning), which basically adds a new alias 'add_slashes', this seemed like the easiest way to go about it. While looking into ext/filter it seems there are no implementations for INPUT_SESSION and INPUT_REQUEST. I doubt there is any intention to implement these so they could be potentials for adding a deprecation for (or simply removal as they just yield an E_WARNING when used anyway)[2]. [1] https://gist.github.com/KalleZ/cce52f230d599501373b15729ec85bfc [2] https://git.php.net/?p=3Dphp-src.git;a=3Dblob;f=3Dext/filter/filter.c;h= =3D56c93199f0bf4f713eeb81c0dfddb910b02b9618;hb=3DHEAD#l547 --=20 regards, Kalle Sommer Nielsen kalle@php.net