Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102619
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJW__o3smiKaCQOFSYqtQzPZJb2=iuR0RojWqshoOadFD7-vHg@mail.gmail.com>
References: <CAF+90c_+GZNrV1SC9q=Y3C=L3LMnoXX7J3zK6=kS9-sMXHZZow@mail.gmail.com>
 <CAJW__o3BsiUoMwxhwPwBwY+OTPt1f=O6aQsHBot-Dat3MRCBpg@mail.gmail.com>
 <CAF+90c_x5ad+oAdPRKaEasMGAUyK+UELHnPEai-aOAPquKVySA@mail.gmail.com>
 <5153610d-abed-b21a-ec55-56d967128cae@gmail.com> <CAJW__o3smiKaCQOFSYqtQzPZJb2=iuR0RojWqshoOadFD7-vHg@mail.gmail.com>
Date: Thu, 5 Jul 2018 22:46:48 +0200
Message-ID: <CAF+90c8z-r4aL8ZVOCU+3V4tc3R2dhWXbDgXc+sOy3Cnb6i=sg@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Stas Malyshev <smalyshev@gmail.com>, Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000074db09057046a5ac"
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000074db09057046a5ac
Content-Type: text/plain; charset="UTF-8"

On Thu, Jul 5, 2018 at 10:42 PM, Kalle Sommer Nielsen <kalle@php.net> wrote:

> Den tor. 5. jul. 2018 kl. 22.22 skrev Stanislav Malyshev <
> smalyshev@gmail.com>:
> >
> > Hi!
> >
> > > After looking into this, I think that FILTER_SANITIZE_MAGIC_QUOTES may
> be a
> > > legitimate filter, which just has a bad name. Next to other filters
> that
> > > perform htmlspecialchars and urlencode, it makes sense that there is
> also a
> > > filter that performs addslashes. Maybe we should just rename this
> filter to
> > > something which is not tainted by the "magic quotes" terminology?
> >
> > Makes sense. There's nothing specially evil in addslashes if used in
> > appropriate context. Also, for those that are newer to PHP, "magic
> > quotes" means very little. So it's a bad name from various perspectives.
> > Having something like FILTER_SANITIZE_ADD_SLASHES would be fine.
>
> Thinking some more about it, I kinda agree with the sentiment and I
> think a rename is much better as it doesn't really hurt. We could add
> an alias constant instead and provoke an E_DEPRECATED if the old one
> is used (given we don't give the filter the same numeric value).
>

Sounds reasonable to me. My only question would be when we would start
emitting the deprecation notice. I'm not a fan of deprecating things in the
same release as the alternative is introduced, so I would suggest to add
the new alias in PHP 7.3 and perform the deprecation in PHP 7.4.

Nikita

--00000000000074db09057046a5ac--