Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102570
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <9274549c-4d08-7a68-77c3-aedfe6dc0962@gmx.de>
References: <d2952f0e-9bcf-1ea5-4768-603e4ee37394@gmx.de> <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com>
 <87863116-5de1-c44d-d751-51e9327807f2@gmx.de> <66c6jdhurlnsaqlegs0epd56b7skj0n20v@4ax.com>
 <6fa23528-ddcd-d998-50cd-ddabcb038b45@gmx.de> <CABBJUpeUT2k4BxuJ1jZz_vtvA44isnxAFfOWADbSrN4KvO-KEw@mail.gmail.com>
 <ed925804-1db0-fa44-11e7-4277a807c2b4@gmx.de> <lovnjd57c3vo3kbkfbkffc5e987cv1fqbt@4ax.com>
 <9274549c-4d08-7a68-77c3-aedfe6dc0962@gmx.de>
Date: Wed, 4 Jul 2018 12:24:10 +0200
Message-ID: <CAF+90c-ae577Rs2wo3MjLc8Mi4H7Vp5fR_L7HFEWwGhuOnEOBw@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Jan Ehrhardt <phpdev@ehrhardt.nl>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ddd7cd057029d40c"
Subject: Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000ddd7cd057029d40c
Content-Type: text/plain; charset="UTF-8"

On Wed, Jul 4, 2018 at 11:32 AM, Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> On 04.07.2018 at 01:16, Jan Ehrhardt wrote:
>
> > Another one: some extensioms suffer from the fact that the macro GC_G
> > was removed from
> > https://github.com/php/php-src/blob/master/Zend/zend_gc.h
> > Some of the removed functionality has been reintroduced in gc_status
> > https://github.com/php/php-src/commits/master/Zend/zend_gc.h
> >
> > Examples using GC_G: v8js, xdebug, tideways.
> > v8js was using gc_active to check if garbage collection was running.
> > I did a wild guess to fix it:
> > https://github.com/Jan-E/v8js/commit/997df065d3cd06a9b11e399458c391
> eb797a850e#diff-dc446a69201ccda44a33d111152f6c8c
>
> This looks wrong, since zend_gc_collect_cycles() actually triggers the
> GC, if I'm not mistaken.
>
> It seems to me that should be something like:
>
>   zend_gc_status status;
>   zend_gc_get_status(&status);
>   if (status.runs) {
>

The correct way to handle this is to implement a proper get_gc() handler,
which will be called in favor of get_properties() during GC.

Nikita

--000000000000ddd7cd057029d40c--