Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102567 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21157 invoked from network); 3 Jul 2018 23:16:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jul 2018 23:16:30 -0000 X-Host-Fingerprint: 62.251.31.78 monitor.xs4all.nl Received: from [62.251.31.78] ([62.251.31.78:20220] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 12/F5-15351-9C30C3B5 for ; Tue, 03 Jul 2018 19:16:27 -0400 To: internals@lists.php.net Date: Wed, 04 Jul 2018 01:16:21 +0200 Message-ID: References: <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com> <87863116-5de1-c44d-d751-51e9327807f2@gmx.de> <66c6jdhurlnsaqlegs0epd56b7skj0n20v@4ax.com> <6fa23528-ddcd-d998-50cd-ddabcb038b45@gmx.de> X-Newsreader: Forte Agent 3.3/32.846 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Posted-By: 62.251.31.78 Subject: Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes From: phpdev@ehrhardt.nl (Jan Ehrhardt) "Christoph M. Becker" in php.internals (Thu, 28 Jun 2018 12:56:43 +0200): >Apparently, zval_ptr_dtor() had to be replaced with >zval_internal_dtor() to avoid a segfault with PHP 7.3. Is this caused >by a change in the engine? If so, is this change documented? Another one: some extensioms suffer from the fact that the macro GC_G was removed from https://github.com/php/php-src/blob/master/Zend/zend_gc.h Some of the removed functionality has been reintroduced in gc_status https://github.com/php/php-src/commits/master/Zend/zend_gc.h Examples using GC_G: v8js, xdebug, tideways. v8js was using gc_active to check if garbage collection was running. I did a wild guess to fix it: https://github.com/Jan-E/v8js/commit/997df065d3cd06a9b11e399458c391eb797a850e#diff-dc446a69201ccda44a33d111152f6c8c Are the changes to zend_gc.h documneted? -- Jan