Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102558 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58400 invoked from network); 3 Jul 2018 14:39:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jul 2018 14:39:01 -0000 Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.208.44 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.208.44 mail-ed1-f44.google.com Received: from [209.85.208.44] ([209.85.208.44:36010] helo=mail-ed1-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F3/B1-15351-18A8B3B5 for ; Tue, 03 Jul 2018 10:38:59 -0400 Received: by mail-ed1-f44.google.com with SMTP id t3-v6so1807637eds.3 for ; Tue, 03 Jul 2018 07:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=p/HM1Na4Tq6SVkehkPPGfOhwg7VkOmt72pn6hTvzUO8=; b=QuyOeBRaXBw4bPCpBYOj+byb6+X55no6Rv4G7wb9h1wVKgLnlW2X8opxzyxxj+9nID +v9HvaKp/wS1MS1uGeScyPwuSmO0MzFWVROqfd/OxpO/YqFUZtmf7uekZktxShk2/3p/ kGrmuN+rwenhNqpB9FTYFLqEa/GT09S1oOk7wqaDfzxtzfntuQvv+KPu1jssw0HE7GkZ VCSs5BhpVGCaEj5hCm4AkOFnZG4/zJ7PUvrrNfa+41KiFVEcgbCaTZrUBy8bsDQew1SD ZLL5RUjWOkykq2/x+mm0Sjb+DHnxBC9NhdspGaGPad32BczVLI54aui3KkQqjo271LFz 1VTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=p/HM1Na4Tq6SVkehkPPGfOhwg7VkOmt72pn6hTvzUO8=; b=O1SbgfRJ/OfJCJkCF3UjdC3keG0nHgsjGODIca3WVb6Zh+6lNC/lBppXv9FImTLYYy g16a7K53bhhEYr2pkPXnwqEGpH6WURFBOarZDegu0UNqfeJ02geqcd8+9cw11qUaqsDv IgNzH3Rs5EHaj5p0HQXDYCBc0OKknFbDQBXBCYNjnf3HQxSKdUHLGIMmql6F1QQYEvpL WXMyC5UzcA0OCuPorYl8Aijb8rrbqY9AU8KRJE094txDr660CxsmZBgHsIkiiUqhJkZJ vsY2YHGCm/epQPw6NWNNOVAtNNs716rZmbOIDsV/1xALNO49+jJ5/8xW4lO4M/5OYD2q knUA== X-Gm-Message-State: APt69E2ANhECXQr1vAZeNa7xEwT+ua+vGxRcJ0Tiv6AhrnPKotEY7AXT AdsyRPf8Ocd4u6N++r/pHkpej1h6cQ0U0nFvuIxXBQ== X-Google-Smtp-Source: AAOMgpfJrquau8akZ5I2KJVGeJiDkXDYVJlfTdP+6vadJGw6vNukt+dnW6fZNAIGt61mo7SOs4i9G79yGo0GHzn1Hso= X-Received: by 2002:a50:e20c:: with SMTP id n12-v6mr22224104edl.253.1530628735464; Tue, 03 Jul 2018 07:38:55 -0700 (PDT) MIME-Version: 1.0 Sender: php@golemon.com Received: by 2002:a50:8617:0:0:0:0:0 with HTTP; Tue, 3 Jul 2018 07:38:54 -0700 (PDT) X-Originating-IP: [206.252.215.26] In-Reply-To: References: <5787528b-eddb-7fcb-c43d-3b4211073ab4@gmx.de> <40eb9575-2bde-05a3-c176-fc98f595c583@gmx.de> Date: Tue, 3 Jul 2018 09:38:54 -0500 X-Google-Sender-Auth: lhsfTEgqP04t2cw_zyAGgWcEh58 Message-ID: To: Nikita Popov Cc: "Christoph M. Becker" , PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Excess arguments for internal functions From: pollita@php.net (Sara Golemon) On Tue, Jul 3, 2018 at 5:11 AM, Nikita Popov wrote: > I'd go for master only as it's technically BC breaking. > Ditto this. > Some people have plans to get rid of the warning/error on too many > arguments to internal functions to make them consistent with user > functions, so maybe this will become unnecessary in the future. But given > the current state of things, it would certainly be good to add > zend_parse_parameters_none() calls where they are missing. > IMO, we should go the other way. Deprecate excess args in userspace functions (making them an error in 8.0). We've had formal variadics in userspace for a long time (5.5 IIRC), this is a solvable problem. I also know that's not going to happen (for well defensible reasons) and I accept that. Felt the need to state my piece though. -Sara