Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102513
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain web.de designates 212.227.17.12 as permitted sender)
To: Rowan Collins <rowan.collins@gmail.com>, Marc Bennewitz <dev@mabe.berlin>
Cc: PHP internals <internals@lists.php.net>
References: <75db877c-ef0b-7d3b-48a8-9879d90352b0@web.de>
 <3242366.BL9MUqXe46@vulcan>
 <CAFMT4Nr6B-+XwzoepUfDHuJVB9xfuJ+f-WBys_FhaERGK8gEQQ@mail.gmail.com>
 <2241856.Iz1GuBRvza@vulcan>
 <a2eb1db6-db91-c51a-8f4a-c7f0920ee775@mabe.berlin>
 <CALKiJKqMV8vOo5TY7pW6TQi8q5zV0ukaGmAzS0o8NzNaHvDhYA@mail.gmail.com>
Message-ID: <e0cc666c-4891-5fa0-31d7-475831aa19c1@web.de>
Date: Thu, 28 Jun 2018 15:02:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CALKiJKqMV8vOo5TY7pW6TQi8q5zV0ukaGmAzS0o8NzNaHvDhYA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC][Under Discussion] Add functions
 array_key_first()and array_key_last()
From: enno.woortmann@web.de ("Woortmann, Enno")

Am 26.06.2018 um 16:42 schrieb Rowan Collins:
> On 26 June 2018 at 08:58, Marc Bennewitz <dev@mabe.berlin> wrote:
>
>> Hi all,
>>
>> I just want to add some information that I feel it's missing in that
>> discussion - I'm sorry if it was mentioned already.
>>
>> 1. It's already possible to extract the key and value of any index
>> position of an array using array_slice: https://3v4l.org/mib99
>>
>> 2. "array_[key|value]_[first|last]($array)" is in my opinion not a good
>> option as it lacks the possibility to extract key/value from any position.
>> Something like "array_[key|value]_index($array, $index)" where $index
>> would be the index position or negative index position from right.
>
> The big advantage of separate functions is that they make the intent clear;
> we could combine all four functions into one: array_index(int $position,
> bool $key), but "array_key_last($something)" is a lot clearer to read than
> "array_index($something, -1, true)". Are there actually use cases for
> getting "the 5th key from the end of the array", common enough to make "the
> last key in the array" harder to write?
>
> Regards,

As well as Rowan I don't see use cases for fetching keys/values at any 
position inside the array for justifying to break up the current 
readable function signatures.
Combining multiple use cases and tasks into a single function always 
offends the single responsibility principle (compare my previous mail) 
and thus should be avoided.

Are there other opinions concerning this topic?
I'd like to finish the discussion soon and move on to the voting phase.

Regards,
Enno