Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102512
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain web.de designates 212.227.17.11 as permitted sender)
To: David Rodrigues <david.proweb@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
References: <75db877c-ef0b-7d3b-48a8-9879d90352b0@web.de>
 <3242366.BL9MUqXe46@vulcan>
 <CAFMT4Nr6B-+XwzoepUfDHuJVB9xfuJ+f-WBys_FhaERGK8gEQQ@mail.gmail.com>
 <2241856.Iz1GuBRvza@vulcan>
 <CAEsg9X3QHZ8bF-2SZxgV9TcG3UjiuZ_7bBXwtdGdm=Uk-N=EAA@mail.gmail.com>
Message-ID: <a44e57cd-bbc0-e8b0-5749-ef438ec57fcf@web.de>
Date: Thu, 28 Jun 2018 14:48:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CAEsg9X3QHZ8bF-2SZxgV9TcG3UjiuZ_7bBXwtdGdm=Uk-N=EAA@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------3A955248F938E6656D625399"
Subject: Re: [PHP-DEV] [RFC][Under Discussion] Add functions
 array_key_first()and array_key_last()
From: enno.woortmann@web.de ("Woortmann, Enno")

--------------3A955248F938E6656D625399
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi David,


thanks for your brainstorming suggestions. My opinion on the options:

> 1. Keys being stored as reference:
>
> $valueOutput = array_first(array $array, ?string &$keyOutput = null);
In my opinion using references to return additional values from a 
function is quiet hacky. I think returning a single value leads to 
significantly clearer code and thus supports the developer.
> 2. Function will returns value or key, by option (similar to
> array_filter()):
> ​​
> array_first(array $array, int $options = ARRAY_VALUE);
> ​
> array_first(array $array, int $options = ARRAY_KEY); ​
This violates the single responsibility principle and consequently isn't 
a good move
> ​3. ​
> F
> ​unction will returns value or key, by boolean argument:
>
> array_first(array $array, bool $returnKeyInsteadOfValue = false);
> array_first(array $array, bool $returnKeyInsteadOfValue = true); ​
Compare 2.
> 4. Specific method to return key instead of value:
>
> array_first(array $array);
> array_first_key(array $array);
This is the RFC just with slightly different function names. I think 
using array_key_first and array_value_first (and the corresponding 
functions for the last array element) provides a consistent naming.
> 5. Consider that keys could be obtained via array_keys(), so array_first()
> should just care about values:
>
> array_first(array_keys($array));
This solution requires a copy of the array (keys) which extends the time 
complexity and the memory usage of the task.

Regards,
Enno

--------------3A955248F938E6656D625399--