Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102511
Return-Path: <cmbecker69@gmx.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 72768 invoked from network); 28 Jun 2018 10:56:44 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 28 Jun 2018 10:56:44 -0000
Authentication-Results: pb1.pair.com smtp.mail=cmbecker69@gmx.de; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=cmbecker69@gmx.de; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.19 as permitted sender)
X-PHP-List-Original-Sender: cmbecker69@gmx.de
X-Host-Fingerprint: 212.227.15.19 mout.gmx.net  
Received: from [212.227.15.19] ([212.227.15.19:35319] helo=mout.gmx.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id EE/58-01794-9EEB43B5 for <internals@lists.php.net>; Thu, 28 Jun 2018 06:56:43 -0400
Received: from [192.168.2.101] ([79.222.41.233]) by mail.gmx.com (mrgmx003
 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Md3li-1fqhwS1B4c-00ICzx; Thu, 28
 Jun 2018 12:56:38 +0200
To: Xinchen Hui <laruence@php.net>
Cc: Jan Ehrhardt <phpdev@ehrhardt.nl>, PHP Internals <internals@lists.php.net>
References: <d2952f0e-9bcf-1ea5-4768-603e4ee37394@gmx.de>
 <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com>
 <87863116-5de1-c44d-d751-51e9327807f2@gmx.de>
 <66c6jdhurlnsaqlegs0epd56b7skj0n20v@4ax.com>
 <6fa23528-ddcd-d998-50cd-ddabcb038b45@gmx.de>
 <CABBJUpeUT2k4BxuJ1jZz_vtvA44isnxAFfOWADbSrN4KvO-KEw@mail.gmail.com>
Message-ID: <ed925804-1db0-fa44-11e7-4277a807c2b4@gmx.de>
Date: Thu, 28 Jun 2018 12:56:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CABBJUpeUT2k4BxuJ1jZz_vtvA44isnxAFfOWADbSrN4KvO-KEw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:uniZM4BNHoE3XPYZa6Brj1a4UgUOmtZC1Pa6p2vsulS3mlXHBfO
 AmAU6Nk4pAx7l7Nx/euH4fPtLCmymk6yth8H4SxN9HygCQHzsNp9Y7cjH/VKuMNLpQ4SAhB
 fFi7PGxpef4lVBwgr4YN+G8bkRXON6lZJgRYrkZCFuOGoFvxcQ3M1rrSMPzmtl4eTBJftJW
 ZExGkM7X6TfHkhX81AYiw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:2UxXUp5u9nI=:VQ680K7cG1k4V9IYmXSCE7
 9wRN/C3aL3tk8sk76WPRO+SjVO0a8JJMEXW+6KajkYy9EciIrh9krvxprhjNiH0/a4Ha+bMzz
 ChFjAcAOySXHpzkKnW/jxHq75bPSp9AqTX92BPlAz9hcqiRc4Bh/4RP72Pw+WC/StKAubX+p9
 WPA0zLAlRzbaDQ9RUFcAY0TX9kFy7ax/eExaCT4np0XKVqLqL8QBMtL88AWCPOeIVQNqTCRDo
 nDRhQ4UfAMr+gpAJXM5Mi+N07sbNjmFrqvN7WdO0ZGsCdQKTufSBDgkPzjnWc0XnH1YJ3m0CQ
 ENNFEtj65LBGwVvaY5/nygoQA0Gknx1UQqme8VSqSDoUldXeIZ5uVY0qTIzNRicoOq0B12ehW
 EA/yidrCjLrYqZiuspPwFYXS4xEIO0njI+MG7sL4/Ey5ikACyGxIxCf1lP71MTYGqJXWoyK0H
 whDpUsc4vbSxJD74QU1DodXK+rZPeyiJ3fEuUCDQfrW5pgnhJAN+UtpTEAYYrxVXyJJbBKsaS
 Zozoq8vzBCIywVSPsQabkyOhDkPyruw6ciTd5vPd78uxezQbNdawJJbaC5ZWToNjx4L0d4mQi
 frzCeyVB7re2XKQXVrtFzvem73xTRReO8ET1oDBT/9+oBrqYt6wM7AG1yAsvI4A13jwtgbtOK
 RNpGOwrG5Repniz9I3y2wzhBDjy3jpS7qfwbq0vz6FHlFGPuM4YWOi8lxg8KCYN8Jk4RwtP9p
 eIfYooqUHXFCD1bpxzajwN1SdSP6osmoc9orefE0+q9NDSqFo6rlPePE2NG4IpKAfz1zum8zT
 gLElpDV
Subject: Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 28.06.2018 at 06:22, Xinchen Hui wrote:

> FAST_CALL should only affects win32.  and it can bring some improvement in
> win32..
> 
> People should use zif_handler instead of define there own from now on, I
> think documented it in UPGRADING is enough....

Thanks!  I've pushed
<http://git.php.net/?p=php-src.git;a=commit;h=2ff26bdf7370fff79d743c390e23cd9f477c855d>.

Please have a look at
<https://github.com/m6w6/ext-http/commit/377d576a6e68def5708cf1ffcd3c233c4dddf356>.
 Apparently, zval_ptr_dtor() had to be replaced with
zval_internal_dtor() to avoid a segfault with PHP 7.3.  Is this caused
by a change in the engine?  If so, is this change documented?

-- 
Christoph M. Becker