Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102509
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.223.176 cause and error)
MIME-Version: 1.0
References: <d2952f0e-9bcf-1ea5-4768-603e4ee37394@gmx.de> <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com>
 <87863116-5de1-c44d-d751-51e9327807f2@gmx.de> <66c6jdhurlnsaqlegs0epd56b7skj0n20v@4ax.com>
 <6fa23528-ddcd-d998-50cd-ddabcb038b45@gmx.de>
In-Reply-To: <6fa23528-ddcd-d998-50cd-ddabcb038b45@gmx.de>
Date: Thu, 28 Jun 2018 12:22:52 +0800
Message-ID: <CABBJUpeUT2k4BxuJ1jZz_vtvA44isnxAFfOWADbSrN4KvO-KEw@mail.gmail.com>
To: cmbecker69@gmx.de
Cc: Jan Ehrhardt <phpdev@ehrhardt.nl>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005b3058056fac1625"
Subject: Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes
From: laruence@php.net (Xinchen Hui)

--0000000000005b3058056fac1625
Content-Type: text/plain; charset="UTF-8"

Hey:
On Wed, Jun 27, 2018 at 9:44 PM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> On 27.06.2018 at 08:47, Jan Ehrhardt wrote:
>
> > "Christoph M. Becker" in php.internals (Tue, 26 Jun 2018 13:15:32
> > +0200):
> >
> >> On 26.06.2018 at 08:42, Jan Ehrhardt wrote:
> >>
> >>>
> https://github.com/php/php-src/blob/php-7.3.0alpha2/UPGRADING.INTERNALS
> >>>
> >>> pecl_http:
> >>> |php_http_client_curl_user.c(190): error C2440: '=': cannot convert
> from 'void (__cdecl *)(zend_execute_data *,zval *)' to 'zif_handler'
> >
> > Mike fixed pecl_http:
> >
> https://github.com/m6w6/ext-http/commit/512f733beac73f37ba4acbcf730ebc6c6de849b6
> >
> > But we ran into another undocumented change:
> >
> https://github.com/m6w6/ext-http/commit/377d576a6e68def5708cf1ffcd3c233c4dddf356
> > `zval_ptr_dtor` had to be replaced by `zval_internal_dtor`.
> >
> >>> taint seems to have comparable errors. See
> >>>
> https://github.com/laruence/taint/commit/9debfe9682d22e172906cd2e7754a8380bf13453#commitcomment-29461798
> >
> > I fixed taint:
> >
> https://github.com/laruence/taint/commit/9debfe9682d22e172906cd2e7754a8380bf13453#commitcomment-29510740
> >
> >>> Can this be fixed and/or added to UPGRADING.INTERNALS?
> >>
> >> Apparently, zif_handler() has been changed to use the ZEND_FASTCALL
> >> calling convention[1] which results in this incompatibility.  Not sure
> >> if that should be reverted, or just documented in UPGRADING.INTERNALS.
> >
> > Any news from the RM's on this?
>
> Well, I'm looking forward to hear from the engine guys. :)
>
FAST_CALL should only affects win32.  and it can bring some improvement in
win32..

People should use zif_handler instead of define there own from now on, I
think documented it in UPGRADING is enough....

thanks

>
> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>


-- 
Xinchen Hui
@Laruence
http://www.laruence.com/

--0000000000005b3058056fac1625--