Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102492
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.208.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABdc3Wp8VW5KZMPhyhMghPkoEDV1AU27dmK=2ES-0DAXJEz3=w@mail.gmail.com>
References: <CAHFNTweakKC+=+UJCWfD0ONcsrVH7rEKrOhnWObeGD+7TBQLjQ@mail.gmail.com>
 <CAOv67gv3OQuLHqKC++BD7A_-fJgzHLkdoc2BnpvD-t5jWGYo-g@mail.gmail.com>
 <CAHFNTwfdyzE_paxh2owFy=8wY0WNijLC2pdL0vAjjOYiXUPv=A@mail.gmail.com>
 <CABdc3WrcYiQT93aEPLT75D+fZqcevoR9qh+=u1XqUYvzRiq9xg@mail.gmail.com> <CABdc3Wp8VW5KZMPhyhMghPkoEDV1AU27dmK=2ES-0DAXJEz3=w@mail.gmail.com>
Date: Wed, 27 Jun 2018 16:46:11 +0100
Message-ID: <CALKiJKrwCZ1TYKr+GSAqQd_4Re6NEg_OYWNrFwP80sxn+NFjEg@mail.gmail.com>
To: =?UTF-8?Q?Micha=C5=82_Brzuchalski?= <michal@brzuchalski.com>
Cc: rudolf.theunissen@gmail.com, Wes <netmo.php@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009d30f9056fa183ed"
Subject: Re: [PHP-DEV] [RFC] User-defined object comparison
From: rowan.collins@gmail.com (Rowan Collins)

--0000000000009d30f9056fa183ed
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 27 June 2018 at 16:24, Micha=C5=82 Brzuchalski <michal@brzuchalski.com> =
wrote:

> There is also one more thing I can think of. If __equals and __compareTo
> methods
> don't have any restrictions for $other parameter typehint then I'll be ab=
le
> to declare
> Foo {
>     public function __compareTo(int $other): int {}
> }
> and will get some error on
> new Foo() =3D=3D new DateTime('now');
>


This can already happen with other magic methods. For instance:

class A {
    public function __set(int $foo, int $bar) {}
}
$a =3D new A;
$a->test =3D 42;

# TypeError: Argument 1 passed to A::__set() must be of the type int,
string given


As long as the implementation correctly unwinds the stack when a Throwable
is encountered (__toString *can't* cope with this, and bails out the
engine), I don't think this is a problem.

Regards,
--=20
Rowan Collins
[IMSoP]

--0000000000009d30f9056fa183ed--