Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102484 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90474 invoked from network); 27 Jun 2018 13:43:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jun 2018 13:43:31 -0000 Authentication-Results: pb1.pair.com header.from=cmbecker69@gmx.de; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=cmbecker69@gmx.de; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.15 as permitted sender) X-PHP-List-Original-Sender: cmbecker69@gmx.de X-Host-Fingerprint: 212.227.15.15 mout.gmx.net Received: from [212.227.15.15] ([212.227.15.15:38229] helo=mout.gmx.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AE/5C-01794-F74933B5 for ; Wed, 27 Jun 2018 09:43:28 -0400 Received: from [192.168.2.101] ([79.222.41.233]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MRoyH-1fj0bK2Urh-00SyuQ; Wed, 27 Jun 2018 15:43:23 +0200 To: Jan Ehrhardt , internals@lists.php.net References: <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com> <87863116-5de1-c44d-d751-51e9327807f2@gmx.de> <66c6jdhurlnsaqlegs0epd56b7skj0n20v@4ax.com> Message-ID: <6fa23528-ddcd-d998-50cd-ddabcb038b45@gmx.de> Date: Wed, 27 Jun 2018 15:43:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <66c6jdhurlnsaqlegs0epd56b7skj0n20v@4ax.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:V1MKV6UtFnFo1Oc+RHurkrcHHx76TnPiRmblVsXtFXkMLA2v/bo o7iMICFM2mvez50cxxub9t9RGWGwfIcOBLRJidpT0/WdtkFpZ2B5rHvrI43Jsc7qrZdJ2lw 5VJ3VgakY+1/C9RFddJaAFIaGgMCwKEUOpgLqnsYO2W0hN71CqiImdR7vx6kq6qSjpo9ixo mtbLfbVqh74IfMksy705Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:owusnHLRD4w=:6saPgCKlBlpIU/979NjWb4 ps5mScef5pJGh3hGWSsdaJvLE3uCe49CKmI66/9QQ3SJIiDWp9QXe+IVsQW+HexHLvhYGPKzy YTtw2szTSRiukFCf6fbUlAty45wixui0byf8MLf3UsJzf/yxTiJR6WQgNANC92NhjLcyGDAoJ 7BSHRSGuWMuTvSwtpvxSR10zyplOffh620Ymw7UWVUYVu3v7uT7kBt2KI+lrAkA4yFuJPszHw PaVnIW0qR/grtYGGGqFVwqM+YjGOaA3D8/B+QTx9AvRNUEVMg+9/j8679c16wEbbRRbcwx84a /+Qx0pTj19mjtgcl8y8+3aNQ8koMUqPh1Z1n0xgv4F3hG29FuKScrpwIAaRwVVGeK45ZraxNq F0UtWS5s+GNH4TgZE1Z5GdkdxJqXao7A5RRPr4Q6F5AHC8NQK51h9qQY5X+Ms52g84ee1U98+ z+tbjVam9DDZRsdxUy6H89p/Bkv2CiBKxRQxAQIWFBbh/jlWJjkEN12+bERdNP9dgL/ghOHfe vfkaxSoOkN85wuHWXX9pGG/nHexGu/aks2b/EKNmZP/RyihcUfTg5q+3ucrdomGH73R5YPSfz kqnBlHpGDiV+4apkhljnRhm0Yy7BWgZvFAT6rDZaXTzPCPpwZFLWipouJopDybljyAOWT07/Q EwU5jJgRdBvQMLOV5oOZsd+3byn9fKdVosC5AyB7HV0CeMzhGeuIx21bz4Kvyn0k4kO1msYyJ JHMz4fWnJmiKctCKnUXagOmsXu+imTHiiHHA+JGZi4Vg+aSWwxh1AnefCmHR2kXoLqeRXKvDX 1D1Ynj1 Subject: Re: PHP 7.3 zif_handler changes From: cmbecker69@gmx.de ("Christoph M. Becker") On 27.06.2018 at 08:47, Jan Ehrhardt wrote: > "Christoph M. Becker" in php.internals (Tue, 26 Jun 2018 13:15:32 > +0200): > >> On 26.06.2018 at 08:42, Jan Ehrhardt wrote: >> >>> https://github.com/php/php-src/blob/php-7.3.0alpha2/UPGRADING.INTERNALS >>> >>> pecl_http: >>> |php_http_client_curl_user.c(190): error C2440: '=': cannot convert from 'void (__cdecl *)(zend_execute_data *,zval *)' to 'zif_handler' > > Mike fixed pecl_http: > https://github.com/m6w6/ext-http/commit/512f733beac73f37ba4acbcf730ebc6c6de849b6 > > But we ran into another undocumented change: > https://github.com/m6w6/ext-http/commit/377d576a6e68def5708cf1ffcd3c233c4dddf356 > `zval_ptr_dtor` had to be replaced by `zval_internal_dtor`. > >>> taint seems to have comparable errors. See >>> https://github.com/laruence/taint/commit/9debfe9682d22e172906cd2e7754a8380bf13453#commitcomment-29461798 > > I fixed taint: > https://github.com/laruence/taint/commit/9debfe9682d22e172906cd2e7754a8380bf13453#commitcomment-29510740 > >>> Can this be fixed and/or added to UPGRADING.INTERNALS? >> >> Apparently, zif_handler() has been changed to use the ZEND_FASTCALL >> calling convention[1] which results in this incompatibility. Not sure >> if that should be reverted, or just documented in UPGRADING.INTERNALS. > > Any news from the RM's on this? Well, I'm looking forward to hear from the engine guys. :) -- Christoph M. Becker