Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102479 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67600 invoked from network); 27 Jun 2018 06:47:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jun 2018 06:47:40 -0000 X-Host-Fingerprint: 62.251.31.78 monitor.xs4all.nl Received: from [62.251.31.78] ([62.251.31.78:12007] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 19/99-01794-903333B5 for ; Wed, 27 Jun 2018 02:47:38 -0400 To: internals@lists.php.net Date: Wed, 27 Jun 2018 08:47:34 +0200 Message-ID: <66c6jdhurlnsaqlegs0epd56b7skj0n20v@4ax.com> References: <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com> <87863116-5de1-c44d-d751-51e9327807f2@gmx.de> X-Newsreader: Forte Agent 3.3/32.846 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Posted-By: 62.251.31.78 Subject: Re: PHP 7.3 zif_handler changes From: phpdev@ehrhardt.nl (Jan Ehrhardt) "Christoph M. Becker" in php.internals (Tue, 26 Jun 2018 13:15:32 +0200): >On 26.06.2018 at 08:42, Jan Ehrhardt wrote: > >> https://github.com/php/php-src/blob/php-7.3.0alpha2/UPGRADING.INTERNALS >> >> pecl_http: >> |php_http_client_curl_user.c(190): error C2440: '=': cannot convert from 'void (__cdecl *)(zend_execute_data *,zval *)' to 'zif_handler' Mike fixed pecl_http: https://github.com/m6w6/ext-http/commit/512f733beac73f37ba4acbcf730ebc6c6de849b6 But we ran into another undocumented change: https://github.com/m6w6/ext-http/commit/377d576a6e68def5708cf1ffcd3c233c4dddf356 `zval_ptr_dtor` had to be replaced by `zval_internal_dtor`. >> taint seems to have comparable errors. See >> https://github.com/laruence/taint/commit/9debfe9682d22e172906cd2e7754a8380bf13453#commitcomment-29461798 I fixed taint: https://github.com/laruence/taint/commit/9debfe9682d22e172906cd2e7754a8380bf13453#commitcomment-29510740 >> Can this be fixed and/or added to UPGRADING.INTERNALS? > >Apparently, zif_handler() has been changed to use the ZEND_FASTCALL >calling convention[1] which results in this incompatibility. Not sure >if that should be reverted, or just documented in UPGRADING.INTERNALS. Any news from the RM's on this? -- Jan