Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102475
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAHFNTweakKC+=+UJCWfD0ONcsrVH7rEKrOhnWObeGD+7TBQLjQ@mail.gmail.com>
References: <CAHFNTweakKC+=+UJCWfD0ONcsrVH7rEKrOhnWObeGD+7TBQLjQ@mail.gmail.com>
Date: Wed, 27 Jun 2018 03:04:49 +0200
Message-ID: <CAOv67gv3OQuLHqKC++BD7A_-fJgzHLkdoc2BnpvD-t5jWGYo-g@mail.gmail.com>
To: Rudolf Theunissen <rudolf.theunissen@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009a43e8056f953368"
Subject: Re: [PHP-DEV] [RFC] User-defined object comparison
From: netmo.php@gmail.com (Wes)

--0000000000009a43e8056f953368
Content-Type: text/plain; charset="UTF-8"

some ideas and concerns:

- I would like to see this in an extension first, i think it's perfectly
doable and people can test it before merging to core

- would be nice if compareTo and equals were used only if left operand and
right operand used the same comparator function.
In other words, $a == $b must not work if $a->__equals and $b->__equals are
two different functions

- otherwise RFC should specify the precedence. if $left operand and $right
operand both have the magic methods, it will call $left->__magic($right),
otherwise, if only the right one has the handler?
  what if the right one has compareTo and the left has only equal? you
probably should add a table that explains which method is called depending
in the availability of the two magic methods in the operands.

- I'd introduce a debug mode that forces php to call both
$left->__equals($right) and $right->__equals($left) so that symmetry is
guaranteed by design. You could do that when "assertions" are active.

gl

--0000000000009a43e8056f953368--