Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102451
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.22 as permitted sender)
To: Jan Ehrhardt <phpdev@ehrhardt.nl>, internals@lists.php.net
References: <d2952f0e-9bcf-1ea5-4768-603e4ee37394@gmx.de>
 <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com>
Message-ID: <87863116-5de1-c44d-d751-51e9327807f2@gmx.de>
Date: Tue, 26 Jun 2018 13:15:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <15n3jdpoiprladjh50u6r2nn1hlmmvea3p@4ax.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: PHP 7.3 zif_handler changes
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 26.06.2018 at 08:42, Jan Ehrhardt wrote:

> Apparently, there were changes in the zend internal functions handler
> (aka zif_handler), but I cannot find any info on it. Neither in the
> linked documents, nor in
> https://github.com/php/php-src/blob/php-7.3.0alpha2/UPGRADING.INTERNALS
> 
> I ran into this in at least three extensions, while compiling on Windows
> (vc15, x64, nts).
> 
> pcs:
> |PCS_Loader.c(575): error C2440: '=': cannot convert from 'zif_handler' to 'void (__cdecl *)(zend_execute_data *,zval *)'
> |PCS_Loader.c(581): error C2440: '=': cannot convert from 'zif_handler' to 'void (__cdecl *)(zend_execute_data *,zval *)'
> |PCS_Loader.c(587): error C2440: '=': cannot convert from 'zif_handler' to 'void (__cdecl *)(zend_execute_data *,zval *)'
> 
> pecl_http:
> |php_http_client_curl_user.c(190): error C2440: '=': cannot convert from 'void (__cdecl *)(zend_execute_data *,zval *)' to 'zif_handler'
> 
> taint seems to have comparable errors. See
> https://github.com/laruence/taint/commit/9debfe9682d22e172906cd2e7754a8380bf13453#commitcomment-29461798
> 
> Can this be fixed and/or added to UPGRADING.INTERNALS?

Apparently, zif_handler() has been changed to use the ZEND_FASTCALL
calling convention[1] which results in this incompatibility.  Not sure
if that should be reverted, or just documented in UPGRADING.INTERNALS.

[1]
<https://github.com/php/php-src/commit/f3aca3c852df1dc169e73c01ef1d47927a51a57a>

<https://github.com/php/php-src/commit/0673aa7f6182dae11798c7a9055dbfd672d87c01>

-- 
Christoph M. Becker