Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102319
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lsces.co.uk designates 185.153.204.204 as permitted sender)
To: internals@lists.php.net
References: <9bcd3495-4d32-dfd0-c91f-29cdc0c582d2@gmail.com>
 <CAF+90c_WKJSSip4Waer6ZrR3x1a7Sp5dSvP70NeLpGvDpvprbQ@mail.gmail.com>
 <dbf68321-3f67-0a8d-adcf-0cba7f8db0d9@lsces.co.uk>
 <f94eeb43-7c4b-9750-1377-e37a401d6392@gmail.com>
 <b1a2a2b4-c722-0a7a-ac92-9f1051eedc2f@lsces.co.uk>
 <CAF+90c-QXFBdgdnXJnqU=PY2mjDvPG8MbSL8Q2EHkNAfvLbPnw@mail.gmail.com>
Message-ID: <da87d051-1230-f681-8086-d72cca78a3c4@lsces.co.uk>
Date: Wed, 20 Jun 2018 11:12:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CAF+90c-QXFBdgdnXJnqU=PY2mjDvPG8MbSL8Q2EHkNAfvLbPnw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Cleaning up unmaintained extensions - interbase
From: lester@lsces.co.uk (Lester Caine)

On 20/06/18 10:25, Nikita Popov wrote:
> Just to clarify which bug I was referring to in that mail, it's this one:
> https://bugs.php.net/bug.php?id=72175
> 
> There are three issues that must be addressed:
>   * The issue in the original bug report: Connecting to the same DB multiple
> times does not work.
>   * The use of zend_list_delete() in *_close() functions, which is
> memory-unsafe.
>   * Incorrect interaction of closing and multiple shared connections. While
> the underlying connection is shared, closing one resource should not close
> all the other ones, but also not result in any leaks (this ties into the
> previous point -- you can't just use zend_list_delete for that!) You may
> need to implement a double resource indirection to properly handle this,
> one holding the actual connection and another holding the connection
> resource.
> 
> If you or someone who is familiar with interbase could fix these issues,
> that would be highly appreciated.

Is there anything in the changes to the code in PHP7 that are ACTUALLY 
to do with changes to interbase/firebird? On website systems I only ever 
have a 'singleton' database connection so don't hit this problem, but 
having just spent half an hour looking through the various notes on 
different lists it seems to be the way zend handles resources in PHP7 
rather than anything to do with the database? THIS is where the nuances 
of PHP7 need to be understood to be able to read your third point ... 
where does one need to understand how the database works?

I am assuming that my next step here is to work out how 
zend_list_delete() is intended to be used, perhaps compare that with 
it's use in other database drivers, and work out just what was broken in 
7.0.3 and why ... and "implement a double resource indirection" ... 
which is much easier to implement if you understand why it is now necessary?

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk