Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102318
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <b1a2a2b4-c722-0a7a-ac92-9f1051eedc2f@lsces.co.uk>
References: <9bcd3495-4d32-dfd0-c91f-29cdc0c582d2@gmail.com>
 <CAF+90c_WKJSSip4Waer6ZrR3x1a7Sp5dSvP70NeLpGvDpvprbQ@mail.gmail.com>
 <dbf68321-3f67-0a8d-adcf-0cba7f8db0d9@lsces.co.uk> <f94eeb43-7c4b-9750-1377-e37a401d6392@gmail.com>
 <b1a2a2b4-c722-0a7a-ac92-9f1051eedc2f@lsces.co.uk>
Date: Wed, 20 Jun 2018 11:25:02 +0200
Message-ID: <CAF+90c-QXFBdgdnXJnqU=PY2mjDvPG8MbSL8Q2EHkNAfvLbPnw@mail.gmail.com>
To: Lester Caine <lester@lsces.co.uk>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009d5f93056f0f5f78"
Subject: Re: [PHP-DEV] Cleaning up unmaintained extensions - interbase
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000009d5f93056f0f5f78
Content-Type: text/plain; charset="UTF-8"

On Tue, Jun 19, 2018 at 11:47 PM, Lester Caine <lester@lsces.co.uk> wrote:

> On 19/06/18 21:48, Stanislav Malyshev wrote:
>
>> What Bug!
>>> It's passing all the test that I run on it perfectly stably otherwise I
>>> would not even bother with PHP7. But the problem supporting ANY driver
>>> is the exotic nature of PHP is just as difficult as the tools it needs
>>> to interface with to make a fully functional stack ...
>>>
>> I have four bugs for interbase and four for firebird submitted just
>> recently, as security issues. Do you want to take care of them? I can
>> assign them to you if you want to take care of them.
>>
>
> The last time I managed to patch php was over 15 years ago, I have not
> been able to get a handle on the new structure used by PHP7 in part because
> I've not had time to do any C coding since. I'm still working on moving
> PHP5.2 code to work on PHP7 while keeping the stack working on W10 and
> maintained versions of SUSE Linux. And some of the stuff I thought I'd
> finished upgrading is not working again :(
>
> I'm not seeing any bugs listed in bugs.php.net that are security risks. I
> don't touch PDO_firebird as it does not handle key Firebird features so
> looking at 'InterBase related' only returns 8 bugs, and one of them is
> missing documentation on the fbird_ aliases that I use in the ADOdb
> Firebird driver. THAT is something I do spend time keeping tidy, and fixes
> some of the niggles raw access encounters, but I will have a look at the
> 2017 bugs that I'd not been aware of ... the other bugs are somewhat exotic
> but not security matters.


Just to clarify which bug I was referring to in that mail, it's this one:
https://bugs.php.net/bug.php?id=72175

There are three issues that must be addressed:
 * The issue in the original bug report: Connecting to the same DB multiple
times does not work.
 * The use of zend_list_delete() in *_close() functions, which is
memory-unsafe.
 * Incorrect interaction of closing and multiple shared connections. While
the underlying connection is shared, closing one resource should not close
all the other ones, but also not result in any leaks (this ties into the
previous point -- you can't just use zend_list_delete for that!) You may
need to implement a double resource indirection to properly handle this,
one holding the actual connection and another holding the connection
resource.

If you or someone who is familiar with interbase could fix these issues,
that would be highly appreciated.

Thanks,
Nikita

--0000000000009d5f93056f0f5f78--