Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102221
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.68 as permitted sender)
MIME-Version: 1.0
References: <EB6971A9-2344-4AA2-BAE6-C4FDC7CF267A@lvht.net> <CAL=_i_mq0jQ_87X8NC21fn=Y3XdWXWfk3ROWG4P0g68mOOEX5A@mail.gmail.com>
In-Reply-To: <CAL=_i_mq0jQ_87X8NC21fn=Y3XdWXWfk3ROWG4P0g68mOOEX5A@mail.gmail.com>
Date: Sun, 10 Jun 2018 18:17:19 -0600
Message-ID: <CAFMT4Npu__xm1i_RXD0wSMju8Kc_C5NvXFW9pgvY8fQRo9g8LQ@mail.gmail.com>
To: Joe Watkins <pthreads@pthreads.org>
Cc: i@lvht.net, internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [VOTE] Fiber API
From: levim@php.net (Levi Morrison)

Replying to Joe's email because I didn't get the original.

On Sun, Jun 10, 2018 at 1:09 PM Joe Watkins <pthreads@pthreads.org> wrote:
>
> This is not ready for voting, please stop the vote.
>
> Bringing stuff to vote that is incomplete, where there is no clear
> consensus, is dangerous.
>
>
> On Sun, Jun 10, 2018 at 2:09 PM, Haitao Lv <i@lvht.net> wrote:
>
> > Hello Internals,
> >
> > The RFC for fiber is now open for a vote. The RFC is available at
> > https://wiki.php.net/rfc/fiber.
> >
> > Voting will be open until June 22th, 2018.
> >
> > Thank you.

I don't think I've listed my complaints yet although I believe others
already covered these:

  1. I don't like `Fiber::` referring to the fiber running. I would
prefer it being passed as a parameter.
  2. As written and implemented this is not sufficiently different
from generators. If fibers supported suspending/resuming C code as
well then it may be powerful enough to justify it, however...
  3. I don't feel this low-level building block is proven.
Theoretically we should be able to build async/await functionality
with it, which is I believe is the real goal. However, until I've seen
it built, demonstrated, and critiqued I don't think we can claim the
the low-level building block is sound.

Sorry for not providing feedback sooner.

Levi Morrison