Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102219
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ku.edu designates 40.107.73.137 as permitted sender)
Received-SPF: Pass (protection.outlook.com: domain of ku.edu designates
 129.237.34.11 as permitted sender) receiver=protection.outlook.com;
 client-ip=129.237.34.11; helo=ex13-csf-cr-11.home.ku.edu;
To: Marco Pivetta <ocramius@gmail.com>
CC: Gabriel Caruso <carusogabriel34@gmail.com>, Dmitry Stogov
	<dmitry@zend.com>, PHP Internals <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [VOTE] Make compact function reports undefined passed
 variables
Thread-Index: AQHUAOoDDd3lD3Xhf0aP6++wx3M38aRaKdUA//+6ojg=
Date: Sun, 10 Jun 2018 19:46:34 +0000
Message-ID: <1528659994400.48879@ku.edu>
References: <CAP=4hCK5BYcUhDGtAHggkAysMZiuraOfBt3TWge0g46GcT0X8g@mail.gmail.com>
 <BN6PR02MB323425E29746D9C173CF67A0BF7A0@BN6PR02MB3234.namprd02.prod.outlook.com>
 <CAP=4hCJxVhF3Y_qmdzGoWs6EsoxhhX-qWtCf26q=Er_C3ZTq0A@mail.gmail.com>
 <1528656103200.14318@ku.edu>,<CADyq6sJYtrG0EaR85T0FLQ5b=D9B7goSCRhYcfN2p5Y55Nd_eQ@mail.gmail.com>
In-Reply-To: <CADyq6sJYtrG0EaR85T0FLQ5b=D9B7goSCRhYcfN2p5Y55Nd_eQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [129.237.14.19]
Content-Type: multipart/alternative;
	boundary="_000_152865999440048879kuedu_"
MIME-Version: 1.0
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report:
	CIP:129.237.34.11;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10019020)(396003)(376002)(39860400002)(346002)(39380400002)(2980300002)(438002)(199004)(189003)(229853002)(426003)(66066001)(6246003)(84326002)(5660300001)(246002)(16586007)(316002)(88552002)(6916009)(19627405001)(39060400002)(446003)(2616005)(11346002)(86362001)(3846002)(4326008)(126002)(117636001)(478600001)(6116002)(486006)(476003)(54896002)(356003)(106466001)(336012)(7596002)(5250100002)(54906003)(2906002)(106002)(2900100001)(7736002)(26005)(8676002)(1411001)(102836004)(186003)(93886005)(97876018)(36756003)(75432002)(76176011)(7696005)(786003)(8936002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR01MB2658;H:ex13-csf-cr-11.home.ku.edu;FPR:;SPF:Pass;LANG:en;PTR:ex13-csf-cr-11.home.ku.edu;A:1;MX:1;
X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD023;1:2XMuQ7RPFL2HtZLPVm/DsSgCWItwKWum+VYFQXtcLkJvP09NvTMm94TDA1LYGB14R8KL+0bRVw+ZF/X5RPAyrhjovYX783Q6Nzb/+AMBkPsSy9Hp/4jvHKq6I/rKaiTR
X-MS-PublicTrafficType: Email
X-Microsoft-Antispam:
	UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BN6PR01MB2658;
X-Microsoft-Exchange-Diagnostics:
	1;BN6PR01MB2658;3:Sygrs7d4r9hONw8H+a4vvsTsxeqtHLzh6glTD2VvkvI9VtEShceLTo2n68DH1OGLgQFjiOMXri+UPXHOoPrBkh4PT9R9z9qie6QvI//ogvbJaZw3Q3/xMy1VM08Fn8ab3LStUhrlOPodDU8yCPh+abgcxedc3E2Yc1akETDJOcCJ72tLvDac57nNM3UjEVQ1dtJRRI1MVLzdvAUaiYOiX003FgzfAwnp86OTpPZpB9LvwO9T3WQK2bvWUmPs3/Qt9IpVgNmfgnUTNg4sUjhM1TraQRTv4HyI5jGU1z9gL7ow8aYiA8UrLFaVRqdBFMLN9Q2GUASvyKZgzF7VMwALRaQNOIRTM0vAobXH93JteXY=;25:6duueuGnWNbmM7tgp3eUxej4Esb+KGgKwm1c5PKqsai1oF2YrGUIvC7u+1fFFa6r4jHMZipeC00rNGSQokxZxW/OHoKBhpYNOg9KnzhCCnsmB2SkTAvqHkbx/dnFr/zmnmSkgFbsYTy9jLpWyPotD0vplclu8xmimJKBMdeLTuwPNChVHNLObebzMCTjPRmcNl6bsauxxqkrFSZ/PTM85TFYfXSS95KSFdcQe78sf0CEJNe0dVJymVhr0x0aJb/pjeQe5fFJ2Xg2o7KOJMN4RrTxmblJslQaodLy/BAvX23PG2q4VdWb3Yf+QpjVtkU48SeOxcsSDGorGOVLma/77Q==
X-MS-TrafficTypeDiagnostic: BN6PR01MB2658:
X-Microsoft-Exchange-Diagnostics:
	1;BN6PR01MB2658;31:j0JXfYlwiXvJGJ0Q01uFFxF03YihlS+avj97XXHIWe0V3rV26O5Exq9cB9MS/5zG/SJ+pwSZLl8QMlk9wv4PzR1XGF27YprBv9f9z7Zqg4y4f56RPeRdirKGKGCQItyYSYi53aji8I3UunGIHE86+vd0DbYtzl8crFWckbtf0UJAGEqsCJJ/C6xpha6aF12dcFGl0i2zM+CJMS90U2FT485PUt8/gHC1GorMsWo+qYI=;20:oznAL3cqFx2m+KGrt/+aSBfRyBqsiViTMK7ad6bqmxQdTUldMTnV7j5OtHKh+hHISs+Lc3kqycJGnoJYYA+QaU43uKhQI6vGkAAZwzeVpnXEgqCeZYY7rI7TqRwoWT5WiiWsMbZEJdmdnCaYZVwKx5g2YiIhemK/fPa+Rn21QJq5YRzgEJDQ/8cvQBoWpBlmeIS+6vyiue6AJPY8SHX77MhmXe8eOmzAcdNfpPV/5ig6wso2denLUYvONTAUBsEkDguk2gfFaHJo0+VBXCg7itdLdwE05oVA5BjI4zzZexgJxWy1a7oiD/slEiB2e0VNM97g/VgbkIrZi1ouy7gkZIJuB75hXhcc0pAFhd8QtNR9CukiVrl6fOT4U0BO4DtXq4OCXg6hpr2BsbL3s9Wb+P3SaUQ2zp5hiFb2Ef5nQnZ9UspgcfrPGMN5E1CHCp3NnziFa6xYLC7RF0tOVJV9mX+ade2t3StE4vcNLn1YQgd8jOBFu1wA0XmhA1m8crW6
X-Microsoft-Antispam-PRVS:
	<BN6PR01MB2658E4D3F712371429A168AFD3790@BN6PR01MB2658.prod.exchangelabs.com>
X-Exchange-Antispam-Report-Test: UriScan:(20558992708506);
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test:
	BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93004095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016);SRVR:BN6PR01MB2658;BCL:0;PCL:0;RULEID:;SRVR:BN6PR01MB2658;
X-Microsoft-Exchange-Diagnostics:
	1;BN6PR01MB2658;4:6GzetTfqk1kmaeS/Xw0rW6GILtXaUw97Uj0s2O6Um6UE4Pboh60aO3yiRVT6YygyhIveiLxnYaWuuA5gReKUGyWv2Yeey87l/WQn8jwXzb8Pu5QVzy7p+FXuSyjgpBG2NtxBtxYpynhpdwkd0kEha42udM77T/73R3b92gXYpG7Up267HgjQ+Sh0tQLotE90yMbTNQPVgVz30dUH5FvLjNR+ZUASB2axedAPsKuDVKn8p3naEnkJM8AlZr0NV+rJVQ8KTyzvzOsKMen0LC/DLlx8LuP91XtmWN2cQITrKiwU4G1V9SACgR5Vpx/dedUp
X-Forefront-PRVS: 0699FCD394
X-Microsoft-Exchange-Diagnostics:
	=?us-ascii?Q?1;BN6PR01MB2658;23:EYGx9d+3CtBOpNK4OZdWhWl0aCk8sPW7jeDgjUt73?=
 =?us-ascii?Q?OQthpOJIpMhcgs1VYKSnFGGNryC2q1x+5SsJ/xUfG/Mk56cs3c3lEjpwIp4L?=
 =?us-ascii?Q?6KEZrzKlGmRhMr1AmF5AqvlOb1jmNszzMmRvpY3lPXDy0eGlVVOSze/UQGxt?=
 =?us-ascii?Q?EAK1zdf2OqOX/YdiBTKiuWzRzpeENSpN0FmInDUX8+puTien+rGCzlDYzSSE?=
 =?us-ascii?Q?VQq05g0RepcwrZqP+d3yIr/mgVxXBVbT6tFQDaBgzGTUTEYYaWEizNSUx4N0?=
 =?us-ascii?Q?qv12KPesnM1WWBgx0+9RdLyEue1OlD58xCQQdHFkjeI+85khhrf9P2TnZmx3?=
 =?us-ascii?Q?ka66rJXK97ue/xYb4EQF5Jgt6kc1Q8wY4ML0HnEGclhCEhXkFblNy3NHJG7S?=
 =?us-ascii?Q?/yoHmOzdTZMNw/JoUYiBHOQcQHHAzNO0nACx+P9wb1dNZS0i8HOq1T2F8+s6?=
 =?us-ascii?Q?ofO3u4fyD5I+k8wY+WLVizSsmYDgQTpTfSNVUhgMauBcwZDxTKbgJCnFBqcj?=
 =?us-ascii?Q?IfOWK/b5OXLeM0vXceoLBFhLNSRmQk8JHDYvf88/IBX/kzEOG7PNWnve/B18?=
 =?us-ascii?Q?SDugKBXpGqNhzo0xlPUpdoIylBBxgdl/omLM3D83sxZoJMWBxmEFijWvgnyh?=
 =?us-ascii?Q?Jh7cogSqHAVDOSDiJVT9MNgpYovLOUs2Vf2mtAsER6EUfY588SjZPnU4ObD/?=
 =?us-ascii?Q?WUWYH76Tbb6Tln3aVhdrEgwqvoLa9OhYD0fw2FlQN7FKpCpoJP/mXq+q1LQm?=
 =?us-ascii?Q?8f5Sf6xsg3W+61KxK9VZTHkotOikNMp8qkHL7HoOIUkLJB7MR5qEQNvY5nEr?=
 =?us-ascii?Q?PNabeEo3v7Hvnd/VoczVqXg5Y+u+zPKVuUQrLaumEVK+55vuH89VdIt9hy9P?=
 =?us-ascii?Q?L7UtsZ882N0T39JAfipTE107W9rgc3y2IbZRwAQZXYPn5OqQgDlUr0AeD8Qq?=
 =?us-ascii?Q?oYaWUNmk0pZBf4hWmfYVv5DErTkZhhvdCGSzpyCQRuoT+CvfWyVPdcomWu4R?=
 =?us-ascii?Q?Nwfrs6hJnqMDV2zorSfkjFrToJaBJUGOm9QrnYwr+7qTBxcrmie2CBKxBg7G?=
 =?us-ascii?Q?03Zy7eah8bZQVPHDVtbhJL+RdzX5Mzd+diMfNCRrXV7IWhzbjMeHWF5o3E81?=
 =?us-ascii?Q?X1scwzDtehuevKCcSHgNXHmZ/s1zVWTzFcG5cbSYXsGlX0/rYBP23t4pdvuZ?=
 =?us-ascii?Q?FtSIGRkuDS3d768xAjrl2hPlN25C8WutPt2UMeeiS5+ouAGnECk43BA/IViM?=
 =?us-ascii?Q?IpwUBM6jYPVy2Mb0yKMm/50oBPleZZ6/JCDTdEZ?=
X-Microsoft-Antispam-Message-Info:
	rIetiRLHHvOqSVETUEBmnDmzBXMOXU0hzWTIhLUgSDFjO9OJamV3vdeNf7mBOnfp5hl9rEZ/w37knNKL5hBR5Qcqemo0fsarlMrUBSI1XHXy2FooBujG1wHadn+Ps6pJ/ZyRNeHsz8vD9DzmVKHtXaRJrFB6HdvvbQlYkXcKybPtOpdmYuEuyYCTDe2wDOXW
X-Microsoft-Exchange-Diagnostics:
	1;BN6PR01MB2658;6:8bDs5HwNEjym7edHLSmjenSb1InYCKOy3Ndx6npL+H8VIlvet8MNXtm0mMWnSxgbbaM7+8LnEpGRoIZBkXGTAug0L7KKduOwXc0akzuG28OPy7fLv5ky+ASwnmllpYcDT89t6bV0i0JVGmdLWjAf4t0q1FvQ2yKtN3y2S0ge6xOPu/7purDqNMMrx1xi6sEi2MRrlWuK779xuDAyejw4fkCGYhbugchC/dVT2DgkTiNdbv0FPtkeq3+kUmRRAcbB/vCygfe8y5uX8EpN4wExgmqIxGDslcBM5H78SqCQwEV9JLUp3Rv7gjiazRc4xEVdjCZ8d55e3yWiS5yL2zxNeaiHADr7EyYhbtLIEr1AKWwyFc+mqQpudDEyeiDwa24yvG0fyLKUb8j8UfIXv29CgtJ1Oip7tjiazo1kPxreg6Izw11RNzf6pjoMlIh08wUZLwg44FtQ5LYr/JTJSOfDXQ==;5:kf1e1GKTcGoLX+hPbvpGBR2m6hzhhxH+ErB5vZz0WSH6RgT/0T2qmuUpaYlnwFHVW5BB3raDVtKlNHowxkquZ4n4HM3lHe2qjo9J0j4c+WcyBMXGtL8MVpxZhfijVdjezpTw5NdxgAXPPuHKJoteCPQAsRImk7h/XbG4esSN/uU=;24:emrPNaSmgxXeT4MmURTdEJbhnsZztujkTTU4Nl7z2zfHxszflTp4L8BD8RbzC7lLTa+1mPivm7rAQkw9GoG3tlrvcsDd0I9IjhsEYXhJngU=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics:
	1;BN6PR01MB2658;7:isYGMXujliwBI2SPXxZFfanVE/1EarQlVTbLeUoI/KE/I2JaWVUno8kO9CBD9F1NG9e72aPTUg6VTb0ihJe1tKSbXgJ4Kujgr5BcSFs9htrwSn1Cjya9gLyk8Xsgk/MCBLfjjJo22Kj/BiEfMe9ZkXOMoYezLenWQ2iUtX3eBhg+oYOGYtJFOTa0ogx0N06RUdtWBficgVjXMmRzfeqTqXIvtgrPLV9NPWyr8VyIhJVYncmnv4pcZ/h/4jOOlqVC
X-MS-Office365-Filtering-Correlation-Id: 4ede997a-29b0-4fde-3d8d-08d5cf0adfba
X-OriginatorOrg: ku.edu
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2018 19:46:35.1692
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ede997a-29b0-4fde-3d8d-08d5cf0adfba
X-MS-Exchange-CrossTenant-Id: 3c176536-afe6-43f5-b966-36feabbe3c1a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3c176536-afe6-43f5-b966-36feabbe3c1a;Ip=[129.237.34.11];Helo=[ex13-csf-cr-11.home.ku.edu]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR01MB2658
Subject: Re: [PHP-DEV] [VOTE] Make compact function reports undefined passed
 variables
From: zrhoffman@ku.edu ("Hoffman, Zachary Robert")

--_000_152865999440048879kuedu_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

>The existence of anything that internally relies on `get_defined_vars()` i=
s a
>blocker for applying further optimisations to the engine (think stack fram=
es),
>which is probably why Dmitry suggested its removal.

I did not know it was an optimization issue. I suppose I could substitute a=
 userland equivalent:

function compact_(array $compact, array $vars)
{
    return array_intersect_key($vars, array_flip($compact));
}

which changes A::c() to

function c()
{
    $d =3D $this->d();
    $a =3D pow($d, $d + 1);
    $c =3D $a ^ 0b1100;
    $b =3D $a - $d;

    return new B(
        compact_(
            $this->b(),
            get_defined_vars()
        )
    );
}

That is not so bad. As far as I am concerned, deprecate away.

--_000_152865999440048879kuedu_--