Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102211 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 50365 invoked from network); 9 Jun 2018 17:25:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Jun 2018 17:25:38 -0000 Authentication-Results: pb1.pair.com smtp.mail=carusogabriel34@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=carusogabriel34@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.171 as permitted sender) X-PHP-List-Original-Sender: carusogabriel34@gmail.com X-Host-Fingerprint: 209.85.128.171 mail-wr0-f171.google.com Received: from [209.85.128.171] ([209.85.128.171:36559] helo=mail-wr0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7C/40-62758-19D0C1B5 for ; Sat, 09 Jun 2018 13:25:37 -0400 Received: by mail-wr0-f171.google.com with SMTP id f16-v6so16308603wrm.3 for ; Sat, 09 Jun 2018 10:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VoHWfxbPsQDnhtKR/5uCg87h0QG3biawLiph8Js3t3Y=; b=SHCb04Ge9d8Btjl53dauPOR/Xg+GJbbkVjl6tE7PxIL0BlAbcONjSVMEK6bgCEj8qw vLl6TLeFCwASEF/kgt6wYFcoBlj6InSt7tl8UTP6sxSH7HQrJnrjAJIrJ0cVGIJ4mWMf 6PdRxU5AXTHx6D8yQppkHZ2dQBRDe5MvV7h5xHZyIeNcIt+aRTBAkzutYzohLYtftdid x/OdHkRxZYOv5u3B2AvQnaZIOJJRWxe7frBDM52NQaNR2H334NXVeJjs/4aJuiCSA+0l KtYEHX8P0argI9mEStW40/d28omYKf/ffa3K0P0ak9tZGQ8PxQUz8aDJTnvrsQuaFlg4 fueQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VoHWfxbPsQDnhtKR/5uCg87h0QG3biawLiph8Js3t3Y=; b=an7cMI3KnrA0pxkoZJ1/lgTjAsCmPWjZOuiAZ54maxQI2KFXB3gIOpgpbtNQoJjGkV uHFARIyyxE/QjGVfaRyekbh58xn/8JGLx10KDPSsdXhTxBMneOvC5wJdTHtXIwiRlrbR Z8fnnQrSMmbU3LSMrDoGDnmew9Bbj/JYQ/SUZjmf5fXtRAuIA1z/6NNZn7D9vw+250B5 ab3vwMh+UVstFDSst3S2107oKqXH0eGDaCwgL4Q+SZ04nUSWNe0vb5xeGPHI/MFKV3JN L3GOTJGRoH0Mvpy64Y86UKhjaRpwjdu0mJhGSxF2h6LNFeviLFsA1+Hd8UVe8qstpJaL Ri/w== X-Gm-Message-State: APt69E2G4Yp+LC6SgI4FP13L59aKPfu9GTeS0QhRC9rVbbaYL9NgyN+b DqyeqqMSZELJFCBpJmJzU5NRCCp1WaMWXQF7PHU= X-Google-Smtp-Source: ADUXVKIPDHhZpSM8EsdXVGStVSQB7zNCQlTboCpD0AXxfAKroboTY+nZz/kE1SdRzzRMbVvYAB4SE12b6Y/NGBUYiOM= X-Received: by 2002:adf:9e8c:: with SMTP id a12-v6mr7641270wrf.170.1528565133940; Sat, 09 Jun 2018 10:25:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Sat, 9 Jun 2018 14:25:22 -0300 Message-ID: To: Dmitry Stogov Cc: PHP Internals Content-Type: multipart/alternative; boundary="000000000000d31e27056e38cdcb" Subject: Re: [PHP-DEV] [VOTE] Make compact function reports undefined passed variables From: carusogabriel34@gmail.com (Gabriel Caruso) --000000000000d31e27056e38cdcb Content-Type: text/plain; charset="UTF-8" > > Hi Gabriel, > >> compact(), extract(), parse_str() (with 1 argument) and >> get_defined_vars() are bad functions, because they access local variables >> indirectly. >> >> They might be considered to be removed in the next major PHP version, >> despite of this fix. >> >> >> Thanks. Dmitry. >> >> > > Hello Dmitry. > > Thanks for this feedback. When I decided to create this RFC adding a > warning, many of friends actually suggested me creating an RFC depracting > `compact`, and complaing with the same arguments as yours. > > Do you think we should do this already in PHP 7.3? > > Thanks. > -- Gabriel Caruso --000000000000d31e27056e38cdcb--