Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102157
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.180 as permitted sender)
To: Joe Watkins <krakjoe@php.net>
References: <CAL=_i_nqLdboRr3jYBTX1_2OOiSePq1ZveiZHfiQSH3DF3WtNw@mail.gmail.com>
Cc: internals@lists.php.net
Message-ID: <885cc344-360a-c8b2-f7f4-833d156940b8@gmail.com>
Date: Tue, 29 May 2018 13:18:42 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CAL=_i_nqLdboRr3jYBTX1_2OOiSePq1ZveiZHfiQSH3DF3WtNw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: RFC WeakRefs
From: zaq178miami@gmail.com (Bogdan Padalko)

On 5/17/18 9:09 AM, Joe Watkins wrote:
> Morning internals,
> 
> I'd like to raise for discussion https://wiki.php.net/rfc/weakrefs
> 
> Am I missing anything ?
> 
> Cheers
> Joe
> 

Hi,

Would we benefit having notification mechanism in weak references? I 
implemented such notification in https://github.com/pinepain/php-ref, 
(used https://github.com/colder/php-weakref as a reference). The only 
issue is that how notification logic should behave when unclean shutdown 
happens, the culprit is some exception thrown which leads to referent 
object destruction and this uncertainty doubles when notification logic 
(callback) also triggers exception. So I bring this question more for 
discussion and it could be definitely implemented later (small working 
feature is better then large non-working one).

Seen that there is weak data structs discussion below, there is 
https://github.com/pinepain/php-object-maps weak/soft map implementatoin 
I made at the time of php-ref extension. It somehow based on java maps 
interface and I think with notification interface for weak refs it's 
fairly simple to implement such maps in userland THOUGH without 
notification, having primitive weakmap in the psl needs to be taken with 
care to do not end up like other psl data structs.