Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102156 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99499 invoked from network); 29 May 2018 09:16:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 May 2018 09:16:16 -0000 Authentication-Results: pb1.pair.com smtp.mail=robin@kingsquare.nl; spf=permerror; sender-id=softfail Authentication-Results: pb1.pair.com header.from=robin@kingsquare.nl; sender-id=softfail Received-SPF: error (pb1.pair.com: domain kingsquare.nl from 77.72.144.59 cause and error) X-PHP-List-Original-Sender: robin@kingsquare.nl X-Host-Fingerprint: 77.72.144.59 2-smtp.kingsquare.nl Received: from [77.72.144.59] ([77.72.144.59:44888] helo=2-smtp.kingsquare.nl) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 00/9D-01681-E5A1D0B5 for ; Tue, 29 May 2018 05:16:15 -0400 Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by 2-smtp.kingsquare.nl (Postfix) with ESMTPSA id 2A750241EC6 for ; Tue, 29 May 2018 09:16:11 +0000 (UTC) Received: by mail-oi0-f50.google.com with SMTP id 11-v6so12399880ois.8 for ; Tue, 29 May 2018 02:16:11 -0700 (PDT) X-Gm-Message-State: ALKqPwclm01Cy5efE7hMZyZX6Sz0sa+0vGVLb/w9W9tzFnnoL8l47hU1 o+wJAFbgxfjnlWLgMRtc7PeDMPLDXDgn0DdXDGc= X-Google-Smtp-Source: AB8JxZoG6CcavhGCawNn9uc6k1ymRneYZtwej5/SeSai1PZKt55b731Y4Say476ZOXBkPdo5vJhpDyMQ3oCBmRlyj3o= X-Received: by 2002:aca:d804:: with SMTP id p4-v6mr8710595oig.29.1527585370168; Tue, 29 May 2018 02:16:10 -0700 (PDT) MIME-Version: 1.0 References: <29dffbd0-b356-08eb-2232-cd02821a0056@php.net> <4e605b02-fe9e-1128-4c98-e274b2ab375d@php.net> <9424d057-0ef4-40ff-187a-496f710ae7b0@php.net> In-Reply-To: Date: Tue, 29 May 2018 11:15:59 +0200 X-Gmail-Original-Message-ID: Message-ID: To: me@kelunik.com Cc: PHP internals Content-Type: multipart/alternative; boundary="0000000000005a6435056d54afa1" Subject: Re: [PHP-DEV] Parse error: Invalid body indentation level From: robin@kingsquare.nl ("Kingsquare.nl - Robin Speekenbrink") --0000000000005a6435056d54afa1 Content-Type: text/plain; charset="UTF-8" Op di 29 mei 2018 om 10:27 schreef Niklas Keller : > Am Di., 29. Mai 2018 um 07:34 Uhr schrieb Sebastian Bergmann < > sebastian@php.net>: > > > Am 28.05.2018 um 22:16 schrieb Nikita Popov: > > > Good point, I have added a note in UPGRADING in > > > > > > https://github.com/php/php-src/commit/c70468b8d3c1d6711da0db84cba30d87d2482e5c > > > > Thank you so much, Nikita! > > > > Can't we ignore any delimiter occurrence that's indented more than the > previous lines to keep the BC break lower? > > Regards, Niklas > Everyone, It might seem obvious and i've probably missed the reasoning, but if the identifier isn't followed by ; then it shouldn't be treated as the delimiter right? Am i missing something here? Just my 2cents ;) --0000000000005a6435056d54afa1--