Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102080
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
Sender: Michael Wallner <mike.php.net@gmail.com>
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
In-Reply-To: <BN6PR02MB3234AD5393026DAFE1960EF2BF8E0@BN6PR02MB3234.namprd02.prod.outlook.com>
Date: Thu, 26 Apr 2018 21:30:38 +0200
Cc: Stanislav Malyshev <smalyshev@gmail.com>,
 Zeev Suraski <zeev@zend.com>,
 Xinchen Hui <laruence@gmail.com>,
 Nikita Popov <nikic@php.net>,
 Bob Weinand <bwoebi@php.net>,
 "Anatol Belski (ab@php.net)" <ab@php.net>,
 PHP internals list <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <B0B8160A-8506-4245-845E-1632860AF635@php.net>
References: <BN6PR02MB323404E036380FA42924D9A7BFB30@BN6PR02MB3234.namprd02.prod.outlook.com>
 <56794c33-a728-d399-2462-b62ba1b7a509@gmail.com>
 <bd88b528-f9ad-dedf-fe07-d38bc3b8fca8@php.net>
 <a03dfaa3-899f-4dae-8752-ba6a117277bf@email.android.com>
 <739e66c6-e60b-005e-acb0-d5c4fb2da11d@php.net>
 <6760eb1f-4345-48d2-a5c2-727cd98e3ac2@email.android.com>
 <BN6PR02MB3234AD5393026DAFE1960EF2BF8E0@BN6PR02MB3234.namprd02.prod.outlook.com>
To: Dmitry Stogov <dmitry@zend.com>
Subject: Re: [PHP-DEV] PHP FFI extenesion
From: mike@php.net (Michael Wallner)

Hey!

> On 26 04 2018, at 20:47, Dmitry Stogov <dmitry@zend.com> wrote:
>=20
> Hi Michael,
>=20
>=20
> I've just tried to run PSI with php-master (32-bit DEBUG build) and =
got SIGSEGV on the simplest test.
>=20
> Use "psi.d/string.psi" and attemt to call psi\strerror(10)
>=20
>=20
> #0  0xf44916ba in psi_call_frame_parse_args (frame=3D0xf426c500, =
execute_data=3D0x0) at /home/dmitry/php/ext-psi/src/call.c:273
> #1  0xf4494fe7 in psi_context_call (C=3D0x92dfe90, execute_data=3D0x0, =
return_value=3D0x8fc0144 <HARDCODED_INI+4>, impl=3D0x9341658)
>    at /home/dmitry/php/ext-psi/src/context.c:250
> #2  0xf4499b44 in psi_ffi_handler (sig=3D0x92e0fa0, result=3D0xffff9760,=
 args=3D0xffff96f0, data=3D0x9341658)
>    at /home/dmitry/php/ext-psi/src/libffi.c:387
> #3  0xf4467a76 in ffi_closure_SYSV_inner () from /lib/libffi.so.6
> #4  0xf4467eb6 in ffi_closure_SYSV () from /lib/libffi.so.6
> #5  0x08701d21 in ZEND_DO_FCALL_BY_NAME_SPEC_RETVAL_USED_HANDLER () at =
/home/dmitry/php/php-master/Zend/zend_vm_execute.h:890
> #6  0x0875fd12 in execute_ex (ex=3D0xf421d020) at =
/home/dmitry/php/php-master/Zend/zend_vm_execute.h:54819
> #7  0x087643b1 in zend_execute (op_array=3D0xf426c460, =
return_value=3D0x0) at =
/home/dmitry/php/php-master/Zend/zend_vm_execute.h:59987
> #8  0x086b0d2f in zend_execute_scripts (type=3D8, retval=3D0x0, =
file_count=3D3) at /home/dmitry/php/php-master/Zend/zend.c:1566
> #9  0x0863cdde in php_execute_script (primary_file=3D0xffffcbbc) at =
/home/dmitry/php/php-master/main/main.c:2467
> #10 0x0876676a in do_cli (argc=3D2, argv=3D0x90e4850) at =
/home/dmitry/php/php-master/sapi/cli/php_cli.c:1011
> #11 0x087673b2 in main (argc=3D2, argv=3D0x90e4850) at =
/home/dmitry/php/php-master/sapi/cli/php_cli.c:1404
>=20
> execute_data is NULL
>=20
>=20
> Did you test ext-psi with php-master?
>=20

I only test on master, but never tested 32bit :-/
https://travis-ci.org/m6w6/ext-psi/jobs/368760446#L2102

>=20
> As I understood, you create libffi callback/closure for each function =
declared in *.psi file(s).
>=20
> And then use it to call a general psi_ffi_handler().
>=20
> Why not to call a general function handler in first place (without any =
ffi magic)?
>=20

Let me think about that. It=E2=80=99s my first with libffi/libjit, so =
maybe I was thinking too complicated and took more corners than I had =
to=E2=80=A6

Thanks,
Mike