Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102053
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 104.47.32.139 cause and error)
To: Jakub Zelenka <bukka@php.net>
CC: PHP internals list <internals@lists.php.net>
Thread-Topic: FPM preloading of PHP files
Thread-Index: AQHT1lerlsdxF46zs0KR37j9XO6GYqQFJc4F
Date: Tue, 17 Apr 2018 16:44:35 +0000
Message-ID: <BN6PR02MB3234013671F23A6981B13632BFB70@BN6PR02MB3234.namprd02.prod.outlook.com>
References: <CAEKnhAFFXqwzm+BW7Zko2zks=XapSOjevcVnHL5tcMxZ4EmWPA@mail.gmail.com>
In-Reply-To: <CAEKnhAFFXqwzm+BW7Zko2zks=XapSOjevcVnHL5tcMxZ4EmWPA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BN6PR02MB3234013671F23A6981B13632BFB70BN6PR02MB3234namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 68f5408b-333d-4b03-3905-08d5a4828089
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2018 16:44:35.1192
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2514
Subject: Re: FPM preloading of PHP files
From: dmitry@zend.com (Dmitry Stogov)

--_000_BN6PR02MB3234013671F23A6981B13632BFB70BN6PR02MB3234namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Jakub,


I though not only about FPM, but a technology for any SAPI.

Pre-loaded classes and functions might be kept in CG() tables, in the same =
way as "internal" ones.

EG() constants and variables may be re-created at start of request, executi=
ng pre-loaded PHP code.

Few years ago, I developed something similar for PHP-5.


Thanks. Dmitry.

________________________________
From: jakub.php@gmail.com <jakub.php@gmail.com> on behalf of Jakub Zelenka =
<bukka@php.net>
Sent: Tuesday, April 17, 2018 5:23:30 PM
To: Dmitry Stogov
Cc: PHP internals list
Subject: FPM preloading of PHP files

Hi Dmitry,

This is a bit different topic to FFI discussion so creating a new thread. Y=
ou wrote this in the FFI extension discussion:

At the same time, we will develop a technology to preload and reuse  PHP fi=
les across requests.
And allow FFI there.

Have you been thinking about it in the FPM context? I'm asking as I have be=
en pondering with a related idea about some restructuring how things work c=
urrently in the FPM. I will try to give a quick overview of the current way=
 how things work (for those who read this and are not familiar with it), th=
e problem that it is already causing and finally the idea that I have. :)

The thing is that at the moment there is just a master process that except =
other things does the module init and spawns children. Each child is then c=
onfigured by the pool configuration which means that it can have a differen=
t effective user id. It's simple and it works in most cases. However there =
is an issue if it tries to access shared resources in other pools running u=
nder different user which can happen due to the fact that the initializatio=
n is done during MINIT by master (root user in such case).  One example is =
the opcache that tries to kill lockers as described in https://bugs.php.net=
/bug.php?id=3D74709 . I think that it's also not ideal to do MINIT as a roo=
t from security point of view (the last security issue is actually good exa=
mple of that - https://bugs.php.net/bug.php?id=3D75605 ). However not sure =
if there are some extension that depends on it.

As you can imagine, it would get even worse if you allow preloading of PHP =
script in master so such implementation would be a no-go IMHO.

What I have been thinking about is to have a new process (I will call it a =
pool manager) for each pool that would except other things spawn and manage=
 children and run under the same user. It would also do the MINIT and it co=
uld possibly preload PHP files and load the libraries for FFI (considering =
there would be a support in the engine for that - some kind of partial exec=
ution or whatever you think would be best). Master would then spawn and man=
age the pool managers as well as doing other things like log handling. That=
 would prevent the user mix up mentioned above - in the example case, the o=
pcache would have separate shared memory for each pool.

WDYT?

Cheers

Jakub


--_000_BN6PR02MB3234013671F23A6981B13632BFB70BN6PR02MB3234namp_--