Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102043
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.50 as permitted sender)
To: Dmitry Stogov <dmitry@zend.com>, Zeev Suraski <zeev@zend.com>,
 Xinchen Hui <laruence@gmail.com>, Nikita Popov <nikic@php.net>,
 Bob Weinand <bwoebi@php.net>, "Anatol Belski (ab@php.net)" <ab@php.net>
Cc: PHP internals list <internals@lists.php.net>
References: <BN6PR02MB323404E036380FA42924D9A7BFB30@BN6PR02MB3234.namprd02.prod.outlook.com>
Openpgp: preference=signencrypt
Message-ID: <56794c33-a728-d399-2462-b62ba1b7a509@gmail.com>
Date: Mon, 16 Apr 2018 16:49:34 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0)
 Gecko/20100101 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <BN6PR02MB323404E036380FA42924D9A7BFB30@BN6PR02MB3234.namprd02.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PHP FFI extenesion
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> I've spent some time thinking about simple FFI for PHP, and finally, borrowed most ideas from LuaJIT.
> 
> This is an initial PoC. It was tested on Linux only.
> 
> 
> https://github.com/dstogov/php-ffi
> 
> 
> I would appreciate review, comments and ideas about missing features and functionality.
> 

Looks interesting. On a cursory look, couple of thoughts:
- I think all the classes involved should be made non-serializable and
non-unserializable.
- Does it load shared libraries, or only uses ones already loaded? If
the former, I think there should be a way to unload them at the request
end (even though it might be performance issue, and may be not possible
if persistent resources are involved), otherwise we leak state between
requests.
- OTOH, people may want to load a set of persistent definitions from a
config file, etc. - the ffi definition probably won't change much, and
having locked down set of FFI interfaces the rest of the code is using
might be beneficial
- Since this thing is dealing with raw pointers, etc., from PHP code,
there may be a lot of crashes from using this extension in a wrong way.
I wonder which facilities we could provide for helping people to debug
it (for people who aren't super-comfortable using gdb on PHP engine).

-- 
Stas Malyshev
smalyshev@gmail.com