Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102014 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 52613 invoked from network); 2 Apr 2018 11:46:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Apr 2018 11:46:02 -0000 Authentication-Results: pb1.pair.com header.from=carusogabriel34@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=carusogabriel34@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.173 as permitted sender) X-PHP-List-Original-Sender: carusogabriel34@gmail.com X-Host-Fingerprint: 209.85.128.173 mail-wr0-f173.google.com Received: from [209.85.128.173] ([209.85.128.173:42834] helo=mail-wr0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9F/52-35059-9F712CA5 for ; Mon, 02 Apr 2018 07:46:01 -0400 Received: by mail-wr0-f173.google.com with SMTP id s18so13366629wrg.9 for ; Mon, 02 Apr 2018 04:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QwmeIR1J22y/0yV0UAN43rYgQXoSyIEOHWfOe8ycHJ4=; b=c74HDL599Bdn+NEdo1ztbwJAvrhhhPL11rJqgzpdj72vyMDo/+HngA0kJWoyeGOYJj Dvgsuy8dKECc4CY77nyEKynkcuDbU/ic95bgK9wQ88fLn6JtinlFTZ+0s90AMIaDyctr 8qPLTTFqCXvNlZDQ23y1eAmdohxQDAS26KT8CvDiDZ/v4D7RwnaSpN14glt+xrqV+F0c xZyVwIhA+Dyh6iu2ywfozGQ/xkJ0OzXsdJ3ub/AYPNjRsD1M8CH745jP0WBPfRdkecsh H621c9+keq4kD4UJXS+aOrtdyAWxl6Svk8Iq2z5j4ER7+ii2Xr1BGwDf/uwv45yQ5AXx K3kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QwmeIR1J22y/0yV0UAN43rYgQXoSyIEOHWfOe8ycHJ4=; b=AZmIXfajniMtQIQPlsUTFeDyjzTU8M5wIDgGceeXabQ+Q8jjKm5dPJ8h9lmE3Q60Qp Uzakbi0Yiag0UefZPLgIzesdXRoUHR5HrrX9e6K2f97aYLhGKRFoP550Er0dJKIZ1JKi 1JrRDgCps1VIRZNmkx/zk66x8RZUw9IZ/oZAiH9zdYJcZuFtldXMd9S9a5DRlEZwpitN 1ti9MP+dnPwCte6fBHTADJM5kZWFXspNvl9wMZKx4aoJ5aMhCVtcXfpOl5w5Up3tRp9J n3w3iev1kEvQXGXYAbfLt/aS2i57XuM4atHOC8wbhD5ScWK+S/hN56BroHI5tKkXTyws 3KqA== X-Gm-Message-State: AElRT7GUXrA2XtpPqlr0pxyvmPz+Sfyu7W0wdveJImZbh5Gnvuig7e7M 6JbGtHGUq6rRK1ec6Mtzj3gp950yiTdBCQzqLfU= X-Google-Smtp-Source: AIpwx48H9tLpzsepMfGf2ZzF70ZAKt9NLWWmIJOoXTctrNHfjOiADkocXmC9uYR8VvX1F+7mnnaZzHmhcSfz/UcW23s= X-Received: by 10.223.157.3 with SMTP id k3mr6861333wre.179.1522669557763; Mon, 02 Apr 2018 04:45:57 -0700 (PDT) MIME-Version: 1.0 References: <2146941281.24754.1522668107133.JavaMail.zimbra@pieterhordijk.com> In-Reply-To: <2146941281.24754.1522668107133.JavaMail.zimbra@pieterhordijk.com> Date: Mon, 02 Apr 2018 11:45:47 +0000 Message-ID: To: Pieter Hordijk Cc: internals Content-Type: multipart/alternative; boundary="f40304388d4c19d4f00568dc22e5" Subject: Re: [PHP-DEV] [RFC][Discussion] Make compact function reports undefined passed variables From: carusogabriel34@gmail.com (Gabriel Caruso) --f40304388d4c19d4f00568dc22e5 Content-Type: text/plain; charset="UTF-8" > > Hey Gabriel, > > What I am missing here is the reason why we should break well defined > behavior of existing functions. > > How is the BC break for all existing code justified? > > Pieter > Hi Pieter. > What I am missing here is the reason why we should break well defined behavior of existing functions. This is something I'd like to discuss about `compact`. I'd like to know why we skip undefined variables instead of report them. `compact` is use in a large scale by the MVC community, by passing variables in the controller and using them in the view. > How is the BC break for all existing code justified? I'd like to start report this undefined variables. Would be one more way to prevent code-smell. IMHO this belongs to the core, not to the userland. Thanks, -- Gabriel Caruso --f40304388d4c19d4f00568dc22e5--