Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102007
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zeyos.com designates 88.99.153.70 as permitted sender)
Date: Thu, 29 Mar 2018 11:51:20 +0200
To: PHP Internals <internals@lists.php.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>,
	Fleshgrinder <php@fleshgrinder.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Message-ID: <20180329095120.C8C0D5FB03@mx.zeyos.com>
Subject: Unnecessary overhead in getdate()
From: ben.coutu@zeyos.com (Benjamin Coutu)

Hello,=0A=0AJust like `[i]date()`, `getdate()` without the `$timestamp` arg=
ument uses the current timestamp.=0A=0AThe code for `[i]date()` (https://gi=
thub.com/php/php-src/blob/master/ext/date/php_date.c#L1276) only makes a sy=
stem call to `time(NULL)` when the `$timestamp` argument is missing. In con=
trast `getdate()` (https://github.com/php/php-src/blob/master/ext/date/php_=
date.c#L1828) always performs a system call to `time(NULL)` even if `$times=
tamp` is supplied by the user.=0A=0AThe code for `getdate()` should mimic w=
hat is done for `date()` to avoid unnecessary system call overhead, hence o=
nly call `time(NULL)` when `!ZEND_NUM_ARGS()`.=0A=0ACan someone please make=
 the appropriate change? Please apologize, but I simply review code and do =
not have a proper C development setup that allows me to supply patches or c=
reate pull requests.=0A=0AThanks,=0A=0ABen=0A=0A-- =0A=0ABenjamin Coutu=0A=
=0Ahttp://www.zeyos.com