Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101968
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.216.171 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <afd0a851-8701-dc52-b3dc-4ede803d8cdd@gmx.de>
References: <CAESVnVqAukZUar4xMk5Pr52u83m2RFq3iN=DRjJM18-izdqX=A@mail.gmail.com>
 <1e29d1b7-dbf4-35d5-61cc-8348c195984a@gmx.de> <CAESVnVpy39iN5KZwHoSrJHUW+v5geUqyPdouVusFsN5FLdWspA@mail.gmail.com>
 <afd0a851-8701-dc52-b3dc-4ede803d8cdd@gmx.de>
Date: Mon, 12 Mar 2018 12:43:19 -0400
Message-ID: <CAESVnVpU8gJr5uhAWP2jnn-OtZz_y2aLTM_QKff0aB+9eVDNtA@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [RFC] Base Conversion Clowniness
From: pollita@php.net (Sara Golemon)

On Mon, Mar 12, 2018 at 11:32 AM, Christoph M. Becker <cmbecker69@gmx.de> wrote:
> I tend to prefer option C (throw a Warning, stop processing, and return
> the value up to that point).  Option B (throw a Warning and return FALSE
> on unexpected characters) might be cleaner, but we're not that picky
> elsewhere, and the return value might not even be checked, and thus
> easily misinterpreted as zero.
>
I've also added option D: Throw an exception.  It's hard to miss, even
if it's inconsistent with the vast majority of our runtime library
(and thus, probably a bad idea).
C is certainly the most consistent with the behavior of (int) cast,
but it's also error prone in other ways.  See also, literally anyone
who has ever been caught by invalid "numeric" user input ever.
B is at least consistent with the spirit of many other standard
library functions, but I agree with you that the output of it is
problematic.
I think we can all agree that A is a terrible option and if someone is
using this as a cheap version of preg_replace('/[^0-9]/', '', $in);
then they deserve to have their code break.

My vote atm, given all of the above would be B, but I'm not super
happy about it.

-Sara