Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:101940 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 15296 invoked from network); 28 Feb 2018 20:26:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Feb 2018 20:26:14 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.54 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 74.125.83.54 mail-pg0-f54.google.com Received: from [74.125.83.54] ([74.125.83.54:40090] helo=mail-pg0-f54.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 04/EB-25585-660179A5 for ; Wed, 28 Feb 2018 15:26:14 -0500 Received: by mail-pg0-f54.google.com with SMTP id g2so1383882pgn.7 for ; Wed, 28 Feb 2018 12:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=6LcbJgSPMj9+4vp7XvMcFkL/0/y8QsjLU8A+Bl2LTIA=; b=ieuEhjVWstn8yupsKV+7q84NBHwwU2TsEYT22zaVPHxR4+HSIpOMLI48hJyVSwGHRY wXxl/0uXWNJIGqYaq42i2YbUhM03JttSnfFmDvA3O1+fisU9/TK1s9yPl0unkX1pyFAG gCJwfS+SvERsNKFFbrAGvXS7Z8HXDXm50yGAl0vate1VyjQc3tyKce7YqVz6ehxqGKDo fT4Bri+UJgPk778krVGIUaiBiRGoSiWOW6dPSw95X00MXxcPwJkmzs1CoajslQWZ3yox N6XexIpuU4kbna7G34D9/QpLX9HIYQIeF8m0Pr2vvgSKlLVzil5rlaxgid5lJc5Vir4L NAQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=6LcbJgSPMj9+4vp7XvMcFkL/0/y8QsjLU8A+Bl2LTIA=; b=CnvCj14JaDy+IFeAnFokBM05CHYAxMuqec9tE55HQ+gyFgwax9Et5yaZPZDT9gh+JC rTePB46NIXYUKnVZ7Hlr0tLpCmi2Ud624n42dR/blLrMzpb5slE9zKN9KDAJ2ahw2m1z Xx4otkJ8ELbLIHxfq/9Y14Jt4771+vlB5oUxItXU7Bv+ZaVdirX2xFR5Kpcyi0E1civS rClE8a358kMJHqYHtpnR+8qlrEfupF4Iv73d+Khdv5zo9sr74V6adgTU4U+RnwHvZz4o skUgJ/9NmbkGUgShaqNOHLPxFVM4AYVMDuFSwOw51b8W/Om8NBVI4huh9a7VEAojkRd6 371w== X-Gm-Message-State: APf1xPApYpfLv+aklhl7QPY2H98cq+XIeZ/8Kqag4tkJTWjoKw6jdlSA yivsz3MsYGznh3U2Iermcx97bFs= X-Google-Smtp-Source: AG47ELt3BIeMvmtOqzfQgbeODoV41dZdKr9e1H5D+vQf+FdC9kQheUnmK0BYGXGa+DTpGkhbVayZmQ== X-Received: by 10.101.100.144 with SMTP id e16mr4588249pgv.315.1519849570879; Wed, 28 Feb 2018 12:26:10 -0800 (PST) Received: from Stas-Pro-2016.lan (c-73-71-144-171.hsd1.ca.comcast.net. [73.71.144.171]) by smtp.gmail.com with ESMTPSA id e23sm4932744pfi.76.2018.02.28.12.26.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Feb 2018 12:26:10 -0800 (PST) To: PHP Internals Message-ID: <72f70269-c6db-db86-43c4-8b69def88d34@gmail.com> Date: Wed, 28 Feb 2018 12:26:09 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: run-tests.php exit code From: smalyshev@gmail.com (Stanislav Malyshev) Hi! When running tests with run-tests.php, if the tests fail, the script will exit with non-zero exit code, but only if REPORT_EXIT_STATUS is set. This was the case since 2002 when this capability has been introduced. I think it would be nice if we reversed the default and made the script use exit code by default, unless NO_EXIT_STATUS is set. All usages of this script that I know (including our own CI suite) use this setting, and I don't think there's a good case for not using it. I think it makes sense to default to the common use case. So: 1. Does it make sense to change the default? 2. Do we want RFC for it? 3. Can we put it in 7.1 or do we want to wait for 7.3? Would be glad to hear everybody's thought on this. -- Stas Malyshev smalyshev@gmail.com