Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101909
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <2B23EFFB-21C3-49E4-9000-B2E0F97E93A2@gmail.com>
References: <CAA69SC79fvaKAT=x=zoUfaqpiK78q68_cdR0vonJAm9FKAwJeQ@mail.gmail.com>
 <CAF+90c-=XtkjmrNV-am3RZ4+XhgJ0WgFCV5Yevjebz2UUh=y3Q@mail.gmail.com>
 <CALKiJKoqPpByQNVMG-3V2Jqjnf=6BkfqEKj96grSdqiJgw1qGg@mail.gmail.com>
 <CAA69SC5z5yxhAHFdbpf_RYBcKia56MZBXuAEk55BhPuiCnFRYw@mail.gmail.com>
 <CAA69SC5irBCAK5k7Adj7-jd-zbTuk+--WhVi0u7e8CnZt81oFw@mail.gmail.com> <2B23EFFB-21C3-49E4-9000-B2E0F97E93A2@gmail.com>
Date: Fri, 23 Feb 2018 15:26:10 +0100
Message-ID: <CAA69SC4m+B9R6x_OP+dRfnO2Vwhadbar=+x1cw3wfo1vj9DQyw@mail.gmail.com>
To: Paul Jones <pmjones88@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c0cb4de23113e0565e1f128"
Subject: Re: [PHP-DEV][RFC][DISCUSSION] Immutability
From: marijic.silvio@gmail.com (=?UTF-8?Q?Silvio_Mariji=C4=87?=)

--94eb2c0cb4de23113e0565e1f128
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks Paul,

I do have rough idea how to go about arrays possibly without recursive
scan, I have to try couple of things, it could work if some checks are
moved to zval level. For now it is in the future scope unless I manage to
handle the within week or two.

First two proposals are valid points. Regarding disabling constructor, that
would fail as soon as you try to write properties in constructor since
object is already "locked".

Best regards and thanks for proposals.

2018-02-23 15:08 GMT+01:00 Paul Jones <pmjones88@gmail.com>:

> Hi Silvio,
>
> I like the RFC.
>
> * * *
>
> I would like to see arrays allowed as immutable properties.
>
> In <http://paul-m-jones.com/archives/6400> I wrote that arrays are
> "probably not practical in most situations" because you have to
> "recursively scan through array properties to make sure that they contain
> only immutable values".
>
> However, I think if the scanning happens at the C level it is not such a
> burden. John Boehr implemented it for the immutable ServerRequest object =
in
> ext-request <http://pecl.php.net/package/request> and it has worked well.
>
> If you do allow arrays, they would have to follow the same rules as the
> immutable object.
>
> Alternatively, perhaps an ImmutableArrayObject would be a good addition o=
r
> followup to the RFC.
>
> * * *
>
> Some further points to harden the implementation:
>
> - I see that resources and references are disallowed (which is good). If
> you have not already done so, you may wish to disallow streams as well.
>
> - You might want to disable setting of undefined public properties, so
> that you cannot "add" mutable public properties to the immutable object.
>
> - Disable the constructor after it has been called, so the object cannot
> be "re-constructed" in place.
>
> * * *
>
> That's all I can think of for now. Thanks for putting this together.
>
>
> --
> Paul M. Jones
> pmjones@pmjones.io
> http://paul-m-jones.com
>
> Modernizing Legacy Applications in PHP
> https://leanpub.com/mlaphp
>
> Solving the N+1 Problem in PHP
> https://leanpub.com/sn1php
>
>
>
>


--=20
Silvio Mariji=C4=87
Software Engineer
SMSGlobal

--94eb2c0cb4de23113e0565e1f128--