Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101870
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAKbGgYiGk_wb++D+w=tntS9NRtVRAQrMzwXEdhcsCXrsBBo2Cw@mail.gmail.com>
References: <CAKbGgYhXjLhLZ2R107yheGh6iEWt_tnr_+NyXm=9k66MYb0MqQ@mail.gmail.com>
 <CAEUnE0dKikZinHjiZmYENB57_e=kSSFfxUU+0Y9=hpH0UX0uRg@mail.gmail.com> <CAKbGgYiGk_wb++D+w=tntS9NRtVRAQrMzwXEdhcsCXrsBBo2Cw@mail.gmail.com>
Date: Wed, 14 Feb 2018 09:40:09 -0600
Message-ID: <CAEUnE0c1+1xAL7wudbw-CFNWw3=xGmogBj_L_Ut2aRQAwrUZtQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="089e082600ac21afa605652deddf"
Subject: Re: [PHP-DEV] About assert()
From: tendoaki@gmail.com (Michael Morris)

--089e082600ac21afa605652deddf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

My earlier reply was through my phone. I've since read the bug report and
saw your note where you couldn't reproduce it.

Assert is a statement in PHP 7.  Try this code

function foo() {
  debug_print_backtrace();
  return true;
}

assert(foo());

In PHP 7 only foo() will be in the backtrace.  In PHP 5 assert will be
listed as well.

What you are proposing has already been done.  It's also why
zend.assertions has three settings: 1: on, -1: off, 0: emulate PHP 5.
Unless you have code on your hands that is breaking when the -1 setting is
used, the 0 setting should never be used.

On Wed, Feb 14, 2018 at 7:43 AM, Pedro Lacerda <pslacerda@gmail.com> wrote:

> The same beharviour, but `assert` as statement also uses 1 character less=
.
>
>
> Em 14 de fev de 2018 10:13 AM, "Michael Morris" <tendoaki@gmail.com>
> escreveu:
>
>
> On Wed, Feb 14, 2018 at 1:16 AM Pedro Lacerda <pslacerda@gmail.com> wrote=
:
>
> > Hi developers,
> >
> > Trying to resolve the bug #75950 (that after long hours I found that I
> > couldn't reproduce), I observed that if `zend.assertions >=3D 0` the
> > generated code inside `assert()` was indeed executed even if
> `assert.active
> > =3D off`. Naturally the function arguments were evaluated before enteri=
ng
> > into the `assert()` function.
> >
> > https://bugs.php.net/bug.php?id=3D75950
> >
> > The point is that will be possible to fully disable assertions setting
> > `assert.active =3D false` after initialization if we turn `assert` into=
 a
> > statement. This can mantain fully backward compatibility. Calling
> > `assert_options(ASSERT_ACTIVE, true)` or `false` after initialization
> would
> > fully enable or disable the functionality. It seems the most sensible
> thing
> > to do.
> >
> > By the way `assert` in Java and Python is an statement, and in C it
> isn't a
> > function.
> >
> > So my question is what is the purpose of mantaining `assert()` a
> function,
> > there are any drawbacks of fully disabling it when `zend.assertions >=
=3D
> 0`?
> >
> >
> > PS: Strange that nobody cared in recent emails about the proposal to a
> > small increase of the testing coverage by doubling the testing time
> > duration, was somewhat interesting.
> >
>
>
> Assert.active is the legacy PHP 5 control. Don=E2=80=99t use it.
>
> zend.assertions -1 has the behavior you want. 0 emulates PHP 5 and
> earlier=E2=80=99s broken implementation of assert. If you don=E2=80=99t h=
ave legacy
> software to babysit, don=E2=80=99t use it.
>
> >
> >
>

--089e082600ac21afa605652deddf--