Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101830
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAKbGgYgj=u=Q03NxsKO5Jqa415meihSFqvrJDO8Mi4uMSnY7Zw@mail.gmail.com>
References: <CAKbGgYjWW18=JeUpirpovc8bAd+ed3T5Fz2GDub+C3uJVck+0w@mail.gmail.com>
 <d981c5d5-b506-5325-bfeb-91e265dd6fd7@gmx.de> <CAKbGgYgj=u=Q03NxsKO5Jqa415meihSFqvrJDO8Mi4uMSnY7Zw@mail.gmail.com>
Date: Sun, 11 Feb 2018 22:32:54 -0300
Message-ID: <CAKbGgYi1mqyQU_viQZ_iygDMx6xeJLtTv8RBXQSyDZwTLrxhkg@mail.gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="94eb2c09cfa8a162960564f9dc58"
Subject: Re: Proposal to run all tests with and without strict_types enabled
From: pslacerda@gmail.com (Pedro Lacerda)

--94eb2c09cfa8a162960564f9dc58
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I agree with `__STRICT_TYPES__`, give me some time so I can try reimplement
`check_strict_types()` as a magic constant.

Maybe the idiom `if (expr) die("reason");` is a bit verbose or cluttered
for a single expression `SKIPIF` section. A `die_if(expr, reason)` function
could be available in that context, or even `skip_if(expr, reason)` because
makes more sense there, albeit is a bit repetitive `SKIPIF skip_if`.

2018-02-11 20:42 GMT-03:00 Pedro Lacerda <pslacerda@gmail.com>:

> I'll check magic constants and give you a response.
>
> The skip message is up to the test developer, however at first I'll
> probably need to change all relevant tests and your message seems
> appropriated to put.
>
> 2018-02-11 20:34 GMT-03:00 Christoph M. Becker <cmbecker69@gmx.de>:
>
>> On 12.02.2018 at 00:03, Pedro Lacerda wrote:
>>
>> > So a new function check_strict_types() was needed to expose
>> > ZEND_ARG_USES_STRICT_TYPES() enabling .phpt tests to check for it in t=
he
>> > --SKIPIF-- section if needed.
>>
>> Umm, I wonder whether a magic constant (say, `__STRICT_TYPES__`) would
>> be more appropriate.
>>
>> > And the implementation draft is at this repository:
>> >
>> > https://github.com/php/php-src/compare/master...pslacerda:
>> experimental/strict_testing?diff=3Dsplit
>>
>> Please have a look at the die()s =E2=80=93 "skip" is omitted, but the re=
st of
>> the message is printed.  Something like
>>
>>   die('skip strict_types is not enabled');
>>
>> might be more appropriate.
>>
>> --
>> Christoph M. Becker
>>
>
>
>
> --
> Atenciosamente,
> Pedro Lacerda
>



--=20
Atenciosamente,
Pedro Lacerda

--94eb2c09cfa8a162960564f9dc58--