Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101829
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <d981c5d5-b506-5325-bfeb-91e265dd6fd7@gmx.de>
References: <CAKbGgYjWW18=JeUpirpovc8bAd+ed3T5Fz2GDub+C3uJVck+0w@mail.gmail.com>
 <d981c5d5-b506-5325-bfeb-91e265dd6fd7@gmx.de>
Date: Sun, 11 Feb 2018 20:42:29 -0300
Message-ID: <CAKbGgYgj=u=Q03NxsKO5Jqa415meihSFqvrJDO8Mi4uMSnY7Zw@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="001a1134fa9ec6846c0564f85173"
Subject: Re: Proposal to run all tests with and without strict_types enabled
From: pslacerda@gmail.com (Pedro Lacerda)

--001a1134fa9ec6846c0564f85173
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I'll check magic constants and give you a response.

The skip message is up to the test developer, however at first I'll
probably need to change all relevant tests and your message seems
appropriated to put.

2018-02-11 20:34 GMT-03:00 Christoph M. Becker <cmbecker69@gmx.de>:

> On 12.02.2018 at 00:03, Pedro Lacerda wrote:
>
> > So a new function check_strict_types() was needed to expose
> > ZEND_ARG_USES_STRICT_TYPES() enabling .phpt tests to check for it in th=
e
> > --SKIPIF-- section if needed.
>
> Umm, I wonder whether a magic constant (say, `__STRICT_TYPES__`) would
> be more appropriate.
>
> > And the implementation draft is at this repository:
> >
> > https://github.com/php/php-src/compare/master...
> pslacerda:experimental/strict_testing?diff=3Dsplit
>
> Please have a look at the die()s =E2=80=93 "skip" is omitted, but the res=
t of
> the message is printed.  Something like
>
>   die('skip strict_types is not enabled');
>
> might be more appropriate.
>
> --
> Christoph M. Becker
>



--=20
Atenciosamente,
Pedro Lacerda

--001a1134fa9ec6846c0564f85173--