Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:101828 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 91879 invoked from network); 11 Feb 2018 23:34:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2018 23:34:54 -0000 Authentication-Results: pb1.pair.com smtp.mail=cmbecker69@gmx.de; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=cmbecker69@gmx.de; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.18 as permitted sender) X-PHP-List-Original-Sender: cmbecker69@gmx.de X-Host-Fingerprint: 212.227.15.18 mout.gmx.net Received: from [212.227.15.18] ([212.227.15.18:58999] helo=mout.gmx.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8D/47-18020-D13D08A5 for ; Sun, 11 Feb 2018 18:34:54 -0500 Received: from [192.168.2.105] ([87.167.204.39]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lp3Lw-1eHAZJ2Mke-00ewFR; Mon, 12 Feb 2018 00:34:49 +0100 To: Pedro Lacerda , internals@lists.php.net References: Message-ID: Date: Mon, 12 Feb 2018 00:34:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:3HC/a7O5D/ttE4D5K+HmkymdcGX5X2/Jy9tkmr3m2DxmbMIFh9x UtXmN4zN8qWFfLnsQUIN7p08tnik3P6ZtYt+ZjpHf9Oed21vmlOwwtg0hnj3WqqTDUvUj9k YNVVon6NZ5bdgQYk+OGYG9RA+lmSqFzFGzKTY7t0lbWFAlxqXFjsoID2LznD5vKOTzIWhFo ViHC0+UmiGv2hlspsY54Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:MVnSq5VogR8=:D5S9BASoZjv0zfxwlLKpIm mBpVG/Mh/wninosZqGiWitruoJD/zwIFBTIARWUVRPkqHjrzaSUeY7s5lnbzrXxBse64354CS 9bdEySnJr9MVxoY5yThmAqC8QE4lP7ZuPpGPrL1TMDq6o/r2QernDzOEcVK2JRH3OYqB8lmen F4todrUW/4TL3DJBlz5zypABQ3lioaWkU/TlH80bBSmFKMJkdoESVpxH9gK9ydEOf8v8XQR6+ CVP62W7qV+GTGRofpKpG6kaXHOZ3qs9H8Lt5MYDJGtaOkYI3ChKrn2NxoH/aZTlRJn7tBL2FV u0hsRxbMteytr4bKr9KBrvc2VvkObe1oQC3Oa66w6RraSiqEHQcLaQI9DcmEPBD4QczygwSc6 7eXB7QZu9huZVmEKIJHacI8aaoAfHqrikvQNzNl9dl7MX4cDbBvfntGYC8QageJovu8HuQ5tt AaeVE3V/FzeyB87w/PzI4iEqvs+47xMMdBEKdsA8HsTNFfCCwjR+/TW5iYiUJ37DY6vNKmSRe AJ9+0ZdK6OBxB8uMVFIlnYmQXPx0QuE/VrdNH76H4tHKjGDTyJ7ovM8X9qXEcZShNvXwYxI9w dKK7lCH/kPSJQ4U85+e/pBH0kgTMiTBVGbve5y9bU15cyMn5L8CPJb/QcBGE1uKR0Bl59CxF1 1GN1H/kGNnCeu0FTmX2cZYqqGnfucM4PIr1cZvv58vm096giZ/2cE7uNUQbXK8p4lmDjBkElk gpUGTBxC+axtnca2r5tB2Jv1FUXhXBTBzWq5zN6/+yiWnDC+36XvWP19UT2pt7ZfigAbhrqyW 2dB5NMTfKKP1mSnzV5fNp7YA/sHT7rsSq058wU4LQrOFlVMnL0= Subject: Re: Proposal to run all tests with and without strict_types enabled From: cmbecker69@gmx.de ("Christoph M. Becker") On 12.02.2018 at 00:03, Pedro Lacerda wrote: > So a new function check_strict_types() was needed to expose > ZEND_ARG_USES_STRICT_TYPES() enabling .phpt tests to check for it in the > --SKIPIF-- section if needed. Umm, I wonder whether a magic constant (say, `__STRICT_TYPES__`) would be more appropriate. > And the implementation draft is at this repository: > > https://github.com/php/php-src/compare/master...pslacerda:experimental/strict_testing?diff=split Please have a look at the die()s – "skip" is omitted, but the rest of the message is printed. Something like die('skip strict_types is not enabled'); might be more appropriate. -- Christoph M. Becker