Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101785
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.18 as permitted sender)
To: Andrea Faulds <ajf@ajf.me>, internals@lists.php.net
References: <dc356798-43b3-c107-9de0-2df2caeca65b@gmx.de>
 <F9.A8.49805.0F2C77A5@pb1.pair.com>
Message-ID: <fb73b6af-16ab-7032-74f2-946249694880@gmx.de>
Date: Tue, 6 Feb 2018 19:32:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <F9.A8.49805.0F2C77A5@pb1.pair.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Subject: Re: What to do with bundled GD's version info?
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Andrea!

On 05.02.2018 at 03:35, Andrea Faulds wrote:

> Christoph M. Becker wrote:
>
>> So the question is how to handle the version information of the bundled
>> libgd for the time being.   With regard to gd_info()['GD Version'] just
>> saying "bundled" (without any compatibility statement) might be a good
>> solution.  However, I'm at a loss how to handle GD_*_VERSION.  Any ideas?
> 
> This might be a bit… maverick, but I wonder if we could get away with a
> semi-numeric string constant. The string "2-phpbundled" would compare
> greater than or equal to 2:
> 
> $ php -r 'var_dump("2-phpbundled" == 2);'
> bool(true)
> $ php -r 'var_dump("2-phpbundled" >= 2);'
> bool(true)
> 
> The problem is that, well, some code out there might want an actual
> integer. It's also a bit ugly…

Thanks!  I don't think this would be helpful, though, since GD 2.0 has
been released around the millenium, and GD 2.0.1 has already been
bundled with PHP since at least PHP 4.3.0.  Therefore we can safely
assume that nobody uses GD 1 anymore.

After reconsideration, it seems to me that we simply can drop the
GD_*_VERSION constants for the bundled libgd.  Anybody who would using
them in combination with the bundled GD is likely to have buggy code,
anyway.  The only sensible thing to do currently would be to check for
`GD_BUNDLED` and to check the PHP version.

I've submitted a respective PR: <https://github.com/php/php-src/pull/3080>.

-- 
Christoph M. Becker