Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101743
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.44 as permitted sender)
To: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Cc: PHP Internals <internals@lists.php.net>
References: <b81d6fa6-853b-26fc-d3a6-8a2eda58c349@mokrynskyi.com>
 <CAMbn9ZETaiG1R7RJVH1_3i99qz_TyHGAbXpBX23W2WyfR4N1-w@mail.gmail.com>
 <0b2d12f4-388c-a3bf-cbbf-417a0f98b386@mokrynskyi.com>
 <e8c4f7b6-6200-d4c4-1b44-bf2dca3cdc7e@gmail.com>
 <4b80d345-d3dc-e7c7-9a73-f2352ddf0d8f@mokrynskyi.com>
Message-ID: <1347dbb7-9eeb-b661-4e8f-473d78d3f81a@gmail.com>
Date: Thu, 1 Feb 2018 15:02:26 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:58.0)
 Gecko/20100101 Thunderbird/58.0
MIME-Version: 1.0
In-Reply-To: <4b80d345-d3dc-e7c7-9a73-f2352ddf0d8f@mokrynskyi.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Potential adoption of run-tests.php replacement
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

On 1/31/18 2:50 AM, Nazar Mokrynskyi wrote:
> The idea is to make filenames more descriptive and sufficient for
> displaying in test results. 

Descriptive - sure, that'd be great, why not. Sufficient - won't happen.
Filenames are not meant to describe complex things, are not suitable for
it and we should not try to put it there. It just won't work.

> This doesn't prevent or discourage anyone from including description
in test file itself when more details need to be included.

Thus, the necessity of supporting --TEST--.

> Moreover, all of the characters from mentioned title are allowed for
> use in file name (at least on Linux) and it would be much more useful
> to see them instead of 001.phpt or bug-1234.phpt.

Yes, but I do not want to have files with such names. And neither, I
expect, do our users - weird filenames are hard to work with, break some
common tools and require extraordinary care to handle them properly. To
illustrate, right now git (tool that is behind Linux kernel, which is
behind pretty much everything on the Internet) can't properly process
some of our test filenames. We don't need more trouble in this
department. We certainly don't need to force people to name their files
"Test whether foo(bar($baz)) crashes if it's called more than twice (bug
#1234).phpt" - that would be a nightmare to work with. We should not be
using filenames for things they weren't meant to be used for.

-- 
Stas Malyshev
smalyshev@gmail.com