Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101739
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4b80d345-d3dc-e7c7-9a73-f2352ddf0d8f@mokrynskyi.com>
References: <b81d6fa6-853b-26fc-d3a6-8a2eda58c349@mokrynskyi.com>
 <CAMbn9ZETaiG1R7RJVH1_3i99qz_TyHGAbXpBX23W2WyfR4N1-w@mail.gmail.com>
 <0b2d12f4-388c-a3bf-cbbf-417a0f98b386@mokrynskyi.com> <e8c4f7b6-6200-d4c4-1b44-bf2dca3cdc7e@gmail.com>
 <4b80d345-d3dc-e7c7-9a73-f2352ddf0d8f@mokrynskyi.com>
Date: Wed, 31 Jan 2018 12:17:48 +0000
Message-ID: <CALKiJKrTH-BZhZFDdSbedaf7W_JUcNjtODY2mGf8gxYVUKcQfw@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c195be0b488b105641177bb"
Subject: Re: [PHP-DEV] Potential adoption of run-tests.php replacement
From: rowan.collins@gmail.com (Rowan Collins)

--94eb2c195be0b488b105641177bb
Content-Type: text/plain; charset="UTF-8"

On 31 January 2018 at 10:50, Nazar Mokrynskyi <nazar@mokrynskyi.com> wrote:

> The idea is to make filenames more descriptive and sufficient for
> displaying in test results. This doesn't prevent or discourage anyone from
> including description in test file itself when more details need to be
> included.
>


Would you propose to apply a bulk rename of all .phpt files currently in
the tree to use their TEST blocks as filenames, or a manual review of each
test? If automating, how would you handle tests whose descriptions are not
unique within a directory? If manual, what kind of naming scheme would you
propose?



> Moreover, all of the characters from mentioned title are allowed for use
> in file name (at least on Linux) and it would be much more useful to see
> them instead of 001.phpt or bug-1234.phpt.



While most characters are allowed in names, some can be irritating to work
with - test descriptions are likely to include things like ", $, * etc
which have to be escaped carefully whenever manipulating the files.
Different filesystems and environments may not handle the same set of
characters, so care would need to be taken to ensure portability of the
test suite.


It seems like a tool which lists the file name and description for each
.phpt file in a directory would bring most of the advantages of such a mass
renaming without the problems.

Regards,
-- 
Rowan Collins
[IMSoP]

--94eb2c195be0b488b105641177bb--