Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:101738 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 68205 invoked from network); 31 Jan 2018 10:50:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Jan 2018 10:50:44 -0000 Authentication-Results: pb1.pair.com header.from=nazar@mokrynskyi.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=nazar@mokrynskyi.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain mokrynskyi.com designates 46.4.12.50 as permitted sender) X-PHP-List-Original-Sender: nazar@mokrynskyi.com X-Host-Fingerprint: 46.4.12.50 mx.mokrynskyi.com Received: from [46.4.12.50] ([46.4.12.50:39638] helo=mx.mokrynskyi.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 63/18-24062-28F917A5 for ; Wed, 31 Jan 2018 05:50:43 -0500 Received: from localhost (localhost [127.0.0.1]) by mx.mokrynskyi.com (Postfix) with ESMTP id 45824EA88 for ; Wed, 31 Jan 2018 10:50:40 +0000 (UTC) Authentication-Results: mx.mokrynskyi.com (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=mokrynskyi.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mokrynskyi.com; h=content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:organization:from:from:references:to:subject :subject; s=dkim; t=1517395840; x=1518259841; bh=6+PywkYIRQtxl3U u7Gm0b8yFYM0gvvSMsMwL1YJdc14=; b=jDAWO8QLcIN6DQ42a+xgV3Tns/el2Ld v8ibcKjeCu+HGWZw7outNVa5kuzxG2ZiOVkCXQQw2y8DAijn3AX38+h04rn9JmfR +nccBLJLcJWAJh0rEztp2vJpYZXF+pLavVlK59di6nj0rP89/f+2nqGh6dm8uE9R j6MDC0nWJg10= X-Virus-Scanned: Debian amavisd-new at mx.mokrynskyi.com Received: from mx.mokrynskyi.com ([127.0.0.1]) by localhost (mx.mokrynskyi.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ucG4UuhClaUA for ; Wed, 31 Jan 2018 10:50:40 +0000 (UTC) Received: from [192.168.1.2] (bomann.znet.kiev.ua [176.122.88.128]) by mx.mokrynskyi.com (Postfix) with ESMTPSA id EC9EDEA75; Wed, 31 Jan 2018 10:50:39 +0000 (UTC) To: Stanislav Malyshev Cc: PHP Internals References: <0b2d12f4-388c-a3bf-cbbf-417a0f98b386@mokrynskyi.com> Organization: CleverStyle, Ecoisme Message-ID: <4b80d345-d3dc-e7c7-9a73-f2352ddf0d8f@mokrynskyi.com> Disposition-Notification-To: Nazar Mokrynskyi Date: Wed, 31 Jan 2018 12:50:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Thunderbird/57.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Potential adoption of run-tests.php replacement From: nazar@mokrynskyi.com (Nazar Mokrynskyi) The idea is to make filenames more descriptive and sufficient for display= ing in test results. This doesn't prevent or discourage anyone from inclu= ding description in test file itself when more details need to be include= d. Moreover, all of the characters from mentioned title are allowed for use = in file name (at least on Linux) and it would be much more useful to see = them instead of 001.phpt or bug-1234.phpt. Sincerely, Nazar Mokrynskyi github.com/nazar-pc 31.01.18 00:26, Stanislav Malyshev =D0=BF=D0=B8=D1=88=D0=B5: > Hi! > >> For instance, it is painful to work with tests in PHP source tree when= they are called 001.phpt, 002.phpt and so on - you need to open each fil= e and read it to see what it intends to test. My tool uses file names ins= tead, which makes browsing source tree with tests more productive and mak= es --TEST-- section redundant (simply ignored). > I think --TEST-- should absolutely be supported. Filename is not nearly > enough to properly describe the content of the test. Something like > "Test whether foo(bar($baz)) crashes if called more than twice (bug > #1234)" is not going to be captured in a filename. Filenames and > informative descriptions are not the same thing. > > I'll look more into what other requirements are needed (one suggestion > would be try to keep option compatibility with the old tool if possible= , > so people could use their old habits) and write later, but I think > supporting proper test descriptions would definitely be one of them. >