Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101736
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.52 as permitted sender)
To: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Cc: PHP Internals <internals@lists.php.net>
References: <b81d6fa6-853b-26fc-d3a6-8a2eda58c349@mokrynskyi.com>
 <CAMbn9ZETaiG1R7RJVH1_3i99qz_TyHGAbXpBX23W2WyfR4N1-w@mail.gmail.com>
 <0b2d12f4-388c-a3bf-cbbf-417a0f98b386@mokrynskyi.com>
Message-ID: <e8c4f7b6-6200-d4c4-1b44-bf2dca3cdc7e@gmail.com>
Date: Tue, 30 Jan 2018 14:26:32 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:58.0)
 Gecko/20100101 Thunderbird/58.0
MIME-Version: 1.0
In-Reply-To: <0b2d12f4-388c-a3bf-cbbf-417a0f98b386@mokrynskyi.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Potential adoption of run-tests.php replacement
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> For instance, it is painful to work with tests in PHP source tree when they are called 001.phpt, 002.phpt and so on - you need to open each file and read it to see what it intends to test. My tool uses file names instead, which makes browsing source tree with tests more productive and makes --TEST-- section redundant (simply ignored).

I think --TEST-- should absolutely be supported. Filename is not nearly
enough to properly describe the content of the test. Something like
"Test whether foo(bar($baz)) crashes if called more than twice (bug
#1234)" is not going to be captured in a filename. Filenames and
informative descriptions are not the same thing.

I'll look more into what other requirements are needed (one suggestion
would be try to keep option compatibility with the old tool if possible,
so people could use their old habits) and write later, but I think
supporting proper test descriptions would definitely be one of them.

-- 
Stas Malyshev
smalyshev@gmail.com