Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101733
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain garfieldtech.com from 66.111.4.27 cause and error)
To: internals@lists.php.net
Date: Tue, 30 Jan 2018 12:13:26 -0600
Message-ID: <28100667.gh41XH5Xuc@vulcan>
In-Reply-To: <CAEUnE0eGNPDdfivttTPvp_4im5HuR20JmTn1EdRbiROkiiqGhA@mail.gmail.com>
References: <CAEUnE0cRR6jtU2GoeiP4SDLJejF4+6zY=fT1FiTKPe6aKwoFqg@mail.gmail.com> <4026445.Wp3pesFrPl@vulcan> <CAEUnE0eGNPDdfivttTPvp_4im5HuR20JmTn1EdRbiROkiiqGhA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1879744.kmXkhGkcey"; micalg="pgp-sha256"; protocol="application/pgp-signature"
Subject: Re: [PHP-DEV][RFC][DISCUSSION] Collection Inspection
From: larry@garfieldtech.com (Larry Garfield)

--nextPart1879744.kmXkhGkcey
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Monday, January 29, 2018 6:46:10 PM CST Michael Morris wrote:
> On Mon, Jan 29, 2018 at 6:16 PM, Larry Garfield <larry@garfieldtech.com>
> 
> wrote:
> > Really, these functions would be useful only on arrays, period.  To allow
> > them
> > on anything else is just dangerous, and on other iterables there are
> > better,
> > more robust approaches (as discussed elsewhere in this thread).
> > 
> > As you've demonstrated they're also quite compact and effective to do in
> > user-
> > space, so unless there's a massive performance difference of moving them
> > to C
> > they don't seem all that appropriate to add to the language directly.
> > 
> > --Larry Garfield
> 
> Didn't you personally raise the issue of hard dependencies doing this sort
> of functionality creates? Implementable in userland or not, this is pretty
> low level functionality.

I don't recall doing so in this thread, but I most likely have on some other 
issue.  It's the sort of comment that I would make. :-)

However, that's for a very commonly used function where just inlining it is 
prohibitive.  As you've demonstrated below, this functionality is easily a one 
liner, and it's a one-liner in an assert statement most likely.  

> Hmm..  If limited to arrays only then array_filter with count is pretty
> close to what we want.
> 
> assert(count(array_filter($a, is_string)) === count($a));
> 
> That's not optimal though - granted assert code doesn't *have* to be
> optimal, but that's still a wordy construction.

Personally I think that's fine, and doesn't need a language-level utility 
function to wrap it any further.

(Yes, that's a subjective metric.  So are most statements about what 
should[n't] be included in the language itself.  Others are welcome to 
disagree, but this falls below my threshold of necessity.)

--Larry Garfield
--nextPart1879744.kmXkhGkcey
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEcBAABCAAGBQJacLXGAAoJEODDCsAxcWF3pYcIAKtypYE8+Fo084ja1m3Rh+nk
mLyg8EriMImnfAgK6gpxlKq/JV/rCa285wn6UOKNMbCD/KfB1JkrtZGp87u+myN6
MeqngJ5/74d3xtHrZuSUJxo+FArbIPQO/Z0K1A1VO7ee7h7NCuuvhobr77p9jWuK
bMrEfXINQY3bjs6aBo1f4d90Std2CqE08ren3fHHFrx2AXZ5TP0chTWz/MmE3vkH
F9PwYitSHS4T4Fyq+h10vXnEB4VhJmK1NmHib6GPQMELeVQVgVRGJKcIzgchs+A6
W89yxu50KxiM/sD06l7LnJltloX1egEf4OXE/oVv6pH/aTZpXbcBwwNmo6Jr7mc=
=SYY9
-----END PGP SIGNATURE-----

--nextPart1879744.kmXkhGkcey--