Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101726
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <b81d6fa6-853b-26fc-d3a6-8a2eda58c349@mokrynskyi.com>
References: <b81d6fa6-853b-26fc-d3a6-8a2eda58c349@mokrynskyi.com>
Date: Mon, 29 Jan 2018 14:10:49 -0800
Message-ID: <CAMbn9ZETaiG1R7RJVH1_3i99qz_TyHGAbXpBX23W2WyfR4N1-w@mail.gmail.com>
To: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c05c48ed62b9a0563f184f2"
Subject: Re: [PHP-DEV] Potential adoption of run-tests.php replacement
From: themattficken@gmail.com (Matt Ficken)

--94eb2c05c48ed62b9a0563f184f2
Content-Type: text/plain; charset="UTF-8"

This is a reimplementation of run-test.php, not just a wrapper (so its
another parser for the PHPT file format). However, its missing support for
many PHPT sections (ie its PHPT format support is incomplete).

See:
https://github.com/nazar-pc/phpt-tests-runner/blob/master/bin/phpt-tests-runner#L117


I created PFTT as a multi-SAPI (CLI, IIS/FastCGI, CLI-WWW, Apache)
multiplatform test tool reimplementing PHPT and PHPUnit(and support for
other common tasks)...

This may give you some clarification of what's missing
http://git.php.net/?p=pftt2.git;a=blob_plain;f=src/com/mostc/pftt/model/core/EPhptSection.java;hb=refs/heads/master

PFTT is a big heavyweight tool (so PFTT shouldn't be in core).
run-tests.php is nice because its a lightweight tool, not overly complex
and minimal to download, so I can easily do `make test` for a custom
build... its just not as good at seriously pounding PHP across multiple
scenarios, SAPIs, filesystems, etc... (built in part to hammer PHP on
Windows to ensure it works well).  Do we really need a 3rd PHPT engine?

It also supports parallel execution (it tests many different scenarios, so
faster execution is critical)... that's a feature that's hard to get right.

-Regards
-M


On Mon, Jan 29, 2018 at 4:57 AM, Nazar Mokrynskyi <nazar@mokrynskyi.com>
wrote:

> Hi internals,
>
> As most of you know, there is this script called run-tests.php which is
> huge in size and hard to maintain.
>
> I also heard some wanted it to support parallel tests execution and
> probably other things.
>
> There is a project I've created a long time ago and still maintaining (
> https://github.com/nazar-pc/phpt-tests-runner) that should be able to run
> most of the tests without changes already with colored output and the whole
> thing is a fraction of run-tests.php's size.
>
> How I'd like to work towards mainlining it into php-src in case there is a
> desire and an agreement on such transition.
>
> If this seems like a good idea, it would be very useful if someone can
> enumerate the list of features that are currently used/needed from
> run-tests.php and which replacement should offer, alongside with features
> on top that might be useful (like parallel execution).
>
> If there was similar discussion already and there is an accepted solution
> there, let me know.
>
> --
> Sincerely, Nazar Mokrynskyi
> github.com/nazar-pc
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--94eb2c05c48ed62b9a0563f184f2--